Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2114393002: Convert video-controls-[mouse, muted, no]* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-controls-[mouse, muted, no]* tests to testharness.js Cleaning up video-controls-[mouse, muted, no]* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/366ab9863a45d639608dc8d66295ad04b158c98d Cr-Commit-Position: refs/heads/master@{#403624}

Patch Set 1 #

Messages

Total messages: 10 (5 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-03 16:05:15 UTC) #3
fs
lgtm
4 years, 5 months ago (2016-07-03 18:02:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114393002/1
4 years, 5 months ago (2016-07-03 18:11:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 01:14:51 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 01:17:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/366ab9863a45d639608dc8d66295ad04b158c98d
Cr-Commit-Position: refs/heads/master@{#403624}

Powered by Google App Engine
This is Rietveld 408576698