Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2114303002:
cc: Add unit tests for non-identity matrix for FilterOperation::MapRect. (Closed)
Descriptioncc: Add unit tests for non-identity matrix for FilterOperation::MapRect.
Also fix a bug where the drop shadow offset did not account for scale in this
matrix (e.g. due to high DPI).
BUG=600821
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/09a522240fb06e640d20a44681ab99c1fb9a20b2
Cr-Commit-Position: refs/heads/master@{#406069}
Patch Set 1 #Patch Set 2 : rebase after skia roll (https://codereview.chromium.org/2114313002 was detected by this test) #
Total comments: 2
Patch Set 3 : SkMatrix::MakeScale #
Messages
Total messages: 24 (8 generated)
Description was changed from ========== cc: Add unit tests for non-identity matrix for FilterOperation::MapRect. Also fix a bug where the drop shadow offset did not account for scale in this matrix (e.g. due to high DPI). BUG=600821 ========== to ========== cc: Add unit tests for non-identity matrix for FilterOperation::MapRect. Also fix a bug where the drop shadow offset did not account for scale in this matrix (e.g. due to high DPI). BUG=600821 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
jbroman@chromium.org changed reviewers: + senorblanco@chromium.org
ping
LGTM
https://codereview.chromium.org/2114303002/diff/20001/cc/output/filter_operat... File cc/output/filter_operations_unittest.cc (right): https://codereview.chromium.org/2114303002/diff/20001/cc/output/filter_operat... cc/output/filter_operations_unittest.cc:18: SkMatrix MakeScaleMatrix(float x_scale, float y_scale) { BTW, this is SkMatrix::MakeScale().
The CQ bit was checked by jbroman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from senorblanco@chromium.org Link to the patchset: https://codereview.chromium.org/2114303002/#ps40001 (title: "SkMatrix::MakeScale")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.blink
For more details, see http://crbug.com/617627.
https://codereview.chromium.org/2114303002/diff/20001/cc/output/filter_operat... File cc/output/filter_operations_unittest.cc (right): https://codereview.chromium.org/2114303002/diff/20001/cc/output/filter_operat... cc/output/filter_operations_unittest.cc:18: SkMatrix MakeScaleMatrix(float x_scale, float y_scale) { On 2016/07/14 at 22:03:14, Stephen White wrote: > BTW, this is SkMatrix::MakeScale(). Done. Don't know how I missed that, it being the very first function in SkMatrix.h. :)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
jbroman@chromium.org changed reviewers: + weiliangc@chromium.org
Wei, mind reviewing as a cc/ owner?
On 2016/07/14 at 23:19:45, jbroman wrote: > Wei, mind reviewing as a cc/ owner? ping weiliangc@
The CQ bit was checked by weiliangc@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.blink
For more details, see http://crbug.com/617627.
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== cc: Add unit tests for non-identity matrix for FilterOperation::MapRect. Also fix a bug where the drop shadow offset did not account for scale in this matrix (e.g. due to high DPI). BUG=600821 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Add unit tests for non-identity matrix for FilterOperation::MapRect. Also fix a bug where the drop shadow offset did not account for scale in this matrix (e.g. due to high DPI). BUG=600821 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/09a522240fb06e640d20a44681ab99c1fb9a20b2 Cr-Commit-Position: refs/heads/master@{#406069} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/09a522240fb06e640d20a44681ab99c1fb9a20b2 Cr-Commit-Position: refs/heads/master@{#406069} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
