third_party/WebKit/LayoutTests/media/media-reparent.html - Issue 2114243002: Convert audio*, media* and video* tests to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/media-reparent.html

Issue 2114243002: Convert audio*, media* and video* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/media/audio-concurrent-supported.html ('K') | « third_party/WebKit/LayoutTests/media/audio-concurrent-supported-expected.txt ('k') | third_party/WebKit/LayoutTests/media/media-reparent-expected.txt » ('j') | third_party/WebKit/LayoutTests/media/video-canvas.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/media-reparent.html

diff --git a/third_party/WebKit/LayoutTests/media/media-reparent.html b/third_party/WebKit/LayoutTests/media/media-reparent.html

index 5a42a927bef519f20aba56b4ed8c4f0b5fe7fd76..58f1e935c785637e077b3e48c6e872fd4ec87eb0 100644

--- a/third_party/WebKit/LayoutTests/media/media-reparent.html

+++ b/third_party/WebKit/LayoutTests/media/media-reparent.html

@@ -1,17 +1,18 @@

-Test that reparenting a removed media tag doesn't crash the process.

-<!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

- (Please avoid writing new tests using video-test.js) -->

-<script src=video-test.js></script>

+<!DOCTYPE html>

+<title>Test that reparenting a removed media tag doesn't crash the process.</title>

+<script src="../resources/testharness.js"></script>

+<script src="../resources/testharnessreport.js"></script>

+<body></body>

-setTimeout(function(){

- var f = document.createElement('iframe');

- document.documentElement.appendChild(f);

- var w = f.contentWindow;

- var div = w.document.createElement('div');

+async_test(function(t) {

+ var iframe = document.createElement('iframe');

+ document.documentElement.appendChild(iframe);

+ var contentWindow = iframe.contentWindow;

+ var div = contentWindow.document.createElement('div');

fs 2016/07/02 18:33:45 Use iframe.contentDocument?

Srirama 2016/07/03 04:31:34 Done.

div.innerHTML = '<audio src="1">';

var node = div;

- f.parentNode.removeChild(f);

+ iframe.parentNode.removeChild(iframe);

document.body.appendChild(node);

- endTestLater();

+ setTimeout(t.step_func_done(), 100);

})

-</script>

+</script>