Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2114243002: Convert audio*, media* and video* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert audio*, media* and video* tests to testharness.js Cleaning up audio*, media* and video* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. Enabled video-canvas.html-disabled test and updated expected values as per current output. BUG=588956 Committed: https://crrev.com/af6014bdb35c114ff5a43c66940dd7330c50d9da Cr-Commit-Position: refs/heads/master@{#403619}

Patch Set 1 #

Total comments: 11

Patch Set 2 : address comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -221 lines) Patch
M third_party/WebKit/LayoutTests/media/audio-concurrent-supported.html View 1 1 chunk +46 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/audio-concurrent-supported-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-reparent.html View 1 1 chunk +12 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-reparent-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/media/video-canvas.html View 1 1 chunk +61 lines, -0 lines 2 comments Download
D third_party/WebKit/LayoutTests/media/video-canvas.html-disabled View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-canvas-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-02 13:34:43 UTC) #8
fs
https://codereview.chromium.org/2114243002/diff/30001/third_party/WebKit/LayoutTests/media/audio-concurrent-supported.html File third_party/WebKit/LayoutTests/media/audio-concurrent-supported.html (right): https://codereview.chromium.org/2114243002/diff/30001/third_party/WebKit/LayoutTests/media/audio-concurrent-supported.html#newcode14 third_party/WebKit/LayoutTests/media/audio-concurrent-supported.html:14: document.write("<audio controls></audio>"); I don't see a reason to use ...
4 years, 5 months ago (2016-07-02 18:33:46 UTC) #9
fs
https://codereview.chromium.org/2114243002/diff/30001/third_party/WebKit/LayoutTests/media/video-canvas.html File third_party/WebKit/LayoutTests/media/video-canvas.html (right): https://codereview.chromium.org/2114243002/diff/30001/third_party/WebKit/LayoutTests/media/video-canvas.html#newcode42 third_party/WebKit/LayoutTests/media/video-canvas.html:42: setTimeout(function() { On 2016/07/02 at 18:33:45, fs wrote: > ...
4 years, 5 months ago (2016-07-02 18:39:44 UTC) #10
Srirama
https://codereview.chromium.org/2114243002/diff/30001/third_party/WebKit/LayoutTests/media/audio-concurrent-supported.html File third_party/WebKit/LayoutTests/media/audio-concurrent-supported.html (right): https://codereview.chromium.org/2114243002/diff/30001/third_party/WebKit/LayoutTests/media/audio-concurrent-supported.html#newcode14 third_party/WebKit/LayoutTests/media/audio-concurrent-supported.html:14: document.write("<audio controls></audio>"); On 2016/07/02 18:33:45, fs wrote: > I ...
4 years, 5 months ago (2016-07-03 04:31:34 UTC) #12
fs
lgtm https://codereview.chromium.org/2114243002/diff/70001/third_party/WebKit/LayoutTests/media/video-canvas.html File third_party/WebKit/LayoutTests/media/video-canvas.html (right): https://codereview.chromium.org/2114243002/diff/70001/third_party/WebKit/LayoutTests/media/video-canvas.html#newcode49 third_party/WebKit/LayoutTests/media/video-canvas.html:49: assert_equals(r, expected.r); I suspect that it'd make sense ...
4 years, 5 months ago (2016-07-03 15:39:42 UTC) #13
Srirama
https://codereview.chromium.org/2114243002/diff/70001/third_party/WebKit/LayoutTests/media/video-canvas.html File third_party/WebKit/LayoutTests/media/video-canvas.html (right): https://codereview.chromium.org/2114243002/diff/70001/third_party/WebKit/LayoutTests/media/video-canvas.html#newcode49 third_party/WebKit/LayoutTests/media/video-canvas.html:49: assert_equals(r, expected.r); On 2016/07/03 15:39:42, fs wrote: > I ...
4 years, 5 months ago (2016-07-03 15:50:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114243002/70001
4 years, 5 months ago (2016-07-03 15:51:03 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years, 5 months ago (2016-07-04 01:09:49 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 01:11:42 UTC) #20
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/af6014bdb35c114ff5a43c66940dd7330c50d9da
Cr-Commit-Position: refs/heads/master@{#403619}

Powered by Google App Engine
This is Rietveld 408576698