[refactor] Remove the AlgorithmRegistry singleton.

[refactor] Remove the AlgorithmRegistry singleton.

The problem with AlgorithmRegistry is that it is not threadsafe.

BUG=357673, 245025
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170672

[eroman, 2014-03-26 03:55:59]

esprehn: You helped me out on IRC; what do you think of this approach?

[eroman, 2014-04-01 02:42:31]

changing reviewer to abarth...

[esprehn, 2014-04-01 04:31:08]

I think you want a static array of the names and the params and you use
sts::lower_bound to search it. I don't understand why you need all these switch
statements.

[abarth-chromium, 2014-04-01 04:58:24]

On 2014/04/01 04:31:08, esprehn wrote:
> I think you want a static array of the names and the params and you use
> sts::lower_bound to search it. I don't understand why you need all these
switch
> statements.

Yeah, std::lower_bound tends to work well.

[eroman, 2014-04-01 21:08:51]

Done --> switched to std::lower_bound().
PTAL

[abarth-chromium, 2014-04-01 21:46:13]

lgtm

https://codereview.chromium.org/211423008/diff/60001/Source/modules/crypto/No...
File Source/modules/crypto/NormalizeAlgorithm.cpp (right):

https://codereview.chromium.org/211423008/diff/60001/Source/modules/crypto/No...
Source/modules/crypto/NormalizeAlgorithm.cpp:194: template <typename Char>
We usually use CharType for this template parameter.

[esprehn, 2014-04-01 22:04:08]

lgtm

[eroman, 2014-04-01 22:28:31]

I replaced the usage of std::is_sorted() with a helper function, since that is
new to C++11 and not available to chromium yet.

The other option would be to get rid of all of the verification code, however I
think it is useful to catch mistakes when adding new entries.

https://codereview.chromium.org/211423008/diff/60001/Source/modules/crypto/No...
File Source/modules/crypto/NormalizeAlgorithm.cpp (right):

https://codereview.chromium.org/211423008/diff/60001/Source/modules/crypto/No...
Source/modules/crypto/NormalizeAlgorithm.cpp:194: template <typename Char>
On 2014/04/01 21:46:13, abarth wrote:
> We usually use CharType for this template parameter.

Done.

[eroman, 2014-04-02 16:49:30]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-04-02 16:49:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/211423008/70001

[commit-bot: I haz the power, 2014-04-02 17:14:20]

Change committed as 170672