Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 211423002: Remove old touch-event based hover/active tests. (Closed)

Created:
6 years, 9 months ago by Zeeshan Qureshi
Modified:
6 years, 9 months ago
Reviewers:
Rick Byers
CC:
blink-reviews
Visibility:
Public.

Description

Remove old touch-event based hover/active tests. All touch based state is set via gesture events so there is no need for these tests. BUG=325930 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169985

Patch Set 1 #

Patch Set 2 : Remove expected output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
D LayoutTests/fast/events/touch/touch-active-state.html View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/fast/events/touch/touch-active-state-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Zeeshan Qureshi
This was the only one that looked like it was testing hover/active state.
6 years, 9 months ago (2014-03-25 17:02:10 UTC) #1
Rick Byers
Thanks. Please remove the expected output file as well (looks like we've actually been testing ...
6 years, 9 months ago (2014-03-25 19:28:16 UTC) #2
Zeeshan Qureshi
Oh yeah, forgot about that.
6 years, 9 months ago (2014-03-25 19:58:55 UTC) #3
Rick Byers
lgtm
6 years, 9 months ago (2014-03-25 20:16:29 UTC) #4
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 9 months ago (2014-03-25 20:30:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/211423002/50001
6 years, 9 months ago (2014-03-25 20:31:04 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 21:39:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 21:39:46 UTC) #8
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 9 months ago (2014-03-25 23:18:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/211423002/50001
6 years, 9 months ago (2014-03-25 23:18:08 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 00:22:42 UTC) #11
Message was sent while issue was closed.
Change committed as 169985

Powered by Google App Engine
This is Rietveld 408576698