Fix loading placeholders for Lo-Fi

third_party/WebKit/Source/core/fetch/ImageResource.cpp

Index: third_party/WebKit/Source/core/fetch/ImageResource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.cpp b/third_party/WebKit/Source/core/fetch/ImageResource.cpp
index c10b9a9682ccdc81789ec0b463f4832a8b7b1a9c..c17e865063c6c0b97cfb75bf6762b1bd8919c36e 100644
--- a/third_party/WebKit/Source/core/fetch/ImageResource.cpp
+++ b/third_party/WebKit/Source/core/fetch/ImageResource.cpp
@@ -517,8 +517,7 @@ void ImageResource::reloadIfLoFi(ResourceFetcher* fetcher)
     m_resourceRequest.setLoFiState(WebURLRequest::LoFiOff);
     if (isLoading())
         m_loader->cancel();
-    else
-        updateImageAndClearBuffer();
+    error(ResourceError::cancelledError(url()));

[hiroshige, 2016/07/04 12:02:29]

Instead of calling error(), how about
    clear();
    m_data.clear();
(i.e. not calling |updateImage(true)|), or
    clear();
    m_data.clear();
    notifyObservers();
(See Patch Set 1 of https://chromiumcodereview.appspot.com/1928823002/#ps1)?

IIUC, the image is not update because, in updateImageAndClearBuffer(),
updateImage(true) is called after clearImage(), and here |m_image| is non-null
and points to the old image, and |m_image| is not re-created or updated after
reloadIfLoFi().
If so, not calling |updateImage(true)| might resolve the problem.

I'd like to avoid using error() here, because calling error() after finish()
looks strange, and doing what is needed for reloading explicitly here would be
clearer than depending on error() (that does many things).

[megjablon, 2016/07/07 00:51:57]

Thanks! Was looking for another way that would load the images properly, but was
confused why updateImageAndClearBuffer didn't work.

     setStatus(NotStarted);
     fetcher->startLoad(this);
 }