Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 2114083002: Add --hot-reload to the test harness. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/standalone.status ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 398986a50f1c4e566d60c9ba3997acdd08c00eac..4e129e81b6c085566c960dfcddb88d2d11a27bbd 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -53,6 +53,7 @@ abstract class CompilerConfiguration {
bool isCsp = configuration['csp'];
bool useCps = configuration['cps_ir'];
bool useBlobs = configuration['use_blobs'];
+ bool hotReload = configuration['hot_reload'];
switch (compiler) {
case 'dart2analyzer':
@@ -89,7 +90,8 @@ abstract class CompilerConfiguration {
isDebug: isDebug,
isChecked: isChecked,
isHostChecked: isHostChecked,
- useSdk: useSdk);
+ useSdk: useSdk,
+ hotReload: hotReload);
default:
throw "Unknown compiler '$compiler'";
}
@@ -149,13 +151,17 @@ abstract class CompilerConfiguration {
/// The "none" compiler.
class NoneCompilerConfiguration extends CompilerConfiguration {
+ final bool hotReload;
+
NoneCompilerConfiguration(
- {bool isDebug, bool isChecked, bool isHostChecked, bool useSdk})
+ {bool isDebug, bool isChecked, bool isHostChecked, bool useSdk,
+ bool hotReload})
: super._subclass(
isDebug: isDebug,
isChecked: isChecked,
isHostChecked: isHostChecked,
- useSdk: useSdk);
+ useSdk: useSdk),
+ this.hotReload = hotReload;
bool get hasCompiler => false;
@@ -172,6 +178,12 @@ class NoneCompilerConfiguration extends CompilerConfiguration {
args.add('--enable_asserts');
args.add('--enable_type_checks');
}
+ if (hotReload) {
+ args.add('--identity-reload');
+ args.add('--reload-every=100000');
+ args.add('--no-background-compilation');
+ args.add('--no-osr');
+ }
return args
..addAll(vmOptions)
..addAll(sharedOptions)
« no previous file with comments | « tests/standalone/standalone.status ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698