Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2114083002: Add --hot-reload to the test harness. (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add --hot-reload to the test harness. ./tools/build.py -mdebug,release runtime ./tools/test.py -mdebug,release --checked --hot-reload BUG=http://dartbug.com/26809 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/eb20b68e87830614e1a50a80c61c0f81e5671eee

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -5 lines) Patch
M runtime/observatory/tests/service/service.status View 1 chunk +16 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +20 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 1 chunk +12 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 4 chunks +15 lines, -3 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 5 months ago (2016-07-01 18:14:29 UTC) #2
Cutch
LGTM after fixing long lines https://codereview.chromium.org/2114083002/diff/1/tools/testing/dart/compiler_configuration.dart File tools/testing/dart/compiler_configuration.dart (right): https://codereview.chromium.org/2114083002/diff/1/tools/testing/dart/compiler_configuration.dart#newcode157 tools/testing/dart/compiler_configuration.dart:157: {bool isDebug, bool isChecked, ...
4 years, 5 months ago (2016-07-01 18:21:09 UTC) #3
rmacnak
https://codereview.chromium.org/2114083002/diff/1/tools/testing/dart/compiler_configuration.dart File tools/testing/dart/compiler_configuration.dart (right): https://codereview.chromium.org/2114083002/diff/1/tools/testing/dart/compiler_configuration.dart#newcode157 tools/testing/dart/compiler_configuration.dart:157: {bool isDebug, bool isChecked, bool isHostChecked, bool useSdk, bool ...
4 years, 5 months ago (2016-07-01 18:27:40 UTC) #4
rmacnak
4 years, 5 months ago (2016-07-01 18:28:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
eb20b68e87830614e1a50a80c61c0f81e5671eee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698