Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2114043002: Two fixes for mash browser_tests on chromes (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Two fixes for mash browser_tests on chromes If sysui crashes and restarts we can hit RootWindowController::OnShelfWindowAvailable() more than once. The code OnShelfWindowAvailable() calls to doesn't expect this and we crash. I'm changing this code to do nothing in this case, which isn't really right, but sysui is going away so this is all temporary. The other change is to disable various services from being created in chrome when in mash. These don't make sense for this config, so disabling. BUG=594600 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/eb82553244fd22a01078f330ea8cefaa160e1901 Cr-Commit-Position: refs/heads/master@{#403512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -14 lines) Patch
M ash/mus/root_window_controller.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 5 months ago (2016-07-01 18:00:20 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 5 months ago (2016-07-01 19:45:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114043002/1
4 years, 5 months ago (2016-07-01 19:47:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 20:22:20 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 20:24:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb82553244fd22a01078f330ea8cefaa160e1901
Cr-Commit-Position: refs/heads/master@{#403512}

Powered by Google App Engine
This is Rietveld 408576698