Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: LayoutTests/media/audio-delete-while-slider-thumb-clicked.html

Issue 211403003: Add a missing null check in SliderThumbElement::stopDragging() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/html/shadow/SliderThumbElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <script src=media-file.js></script> 4 <script src=media-file.js></script>
5 <script src=video-test.js></script> 5 <script src=video-test.js></script>
6 <script src=media-controls.js></script> 6 <script src=media-controls.js></script>
7 <script> 7 <script>
8 if (window.testRunner) { 8 if (window.testRunner) {
9 testRunner.dumpAsText(); 9 testRunner.dumpAsText();
10 testRunner.waitUntilDone(); 10 testRunner.waitUntilDone();
11 } 11 }
12 12
13 function log(msg) 13 function log(msg)
14 { 14 {
15 var console = document.getElementById('console'); 15 var console = document.getElementById('console');
16 console.innerHTML = console.innerHTML + msg + "<br>"; 16 console.innerHTML = console.innerHTML + msg + "<br>";
17 } 17 }
18 18
19 function forceGC()
20 {
21 if (window.GCController)
22 return GCController.collect();
23
24 // Force garbage collection
25 for (var ndx = 0; ndx < 99000; ndx++)
26 var str = new String("1234");
27 }
28
19 function buttonClick() 29 function buttonClick()
20 { 30 {
31 forceGC();
32
21 if (document.getElementById('audio')) 33 if (document.getElementById('audio'))
22 log("<br>FAIL: audio element not deleted!!"); 34 log("<br>FAIL: audio element not deleted!!");
23 35
24 log("<br>clicking button"); 36 log("<br>clicking button");
25 37
26 // click the button 38 // click the button
27 var button = document.getElementById('button'); 39 var button = document.getElementById('button');
28 eventSender.mouseMoveTo(button.offsetLeft + 20, button.offsetTop + 7); 40 eventSender.mouseMoveTo(button.offsetLeft + 20, button.offsetTop + 7);
29 eventSender.mouseDown(); 41 eventSender.mouseDown();
30 eventSender.mouseUp(); 42 eventSender.mouseUp();
31 43
32 testRunner.notifyDone(); 44 testRunner.notifyDone();
33 } 45 }
34 46
35 function deleteAudio() 47 function deleteAudio()
36 { 48 {
37 var audio = document.getElementById('audio'); 49 var audio = document.getElementById('audio');
38 if (!audio) 50 if (!audio)
39 return; 51 return;
40 52
41 log("<br>deleting audio element"); 53 log("<br>deleting audio element");
42 audio.parentNode.removeChild(audio); 54 audio.parentNode.removeChild(audio);
43 55
44 setTimeout(buttonClick, 10); 56 setTimeout(buttonClick, 10);
45 } 57 }
46 58
47 function drag() 59 function drag()
48 { 60 {
49 if (!window.testRunner) 61 if (!window.testRunner)
50 return; 62 return;
51 63
52 testRunner.dumpAsText(); 64 testRunner.dumpAsText();
53 testRunner.waitUntilDone(); 65 testRunner.waitUntilDone();
54 66
55 var audio = document.getElementById('audio'); 67 var audio = document.getElementById('audio');
56 var seekCoords; 68 var seekCoords;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 </head> 100 </head>
89 <body onload="start()"> 101 <body onload="start()">
90 This tests that events don't continue to target a slider thumb if the me dia element is deleted while scrubbing. 102 This tests that events don't continue to target a slider thumb if the me dia element is deleted while scrubbing.
91 <br> 103 <br>
92 <input type="button" id="button" value="Click Me!" onmouseup="log('butto n click!')"> 104 <input type="button" id="button" value="Click Me!" onmouseup="log('butto n click!')">
93 <br> 105 <br>
94 <audio id="audio" autoplay onplaying="drag()" controls></audio><br><br> 106 <audio id="audio" autoplay onplaying="drag()" controls></audio><br><br>
95 <div id="console"></div> 107 <div id="console"></div>
96 </body> 108 </body>
97 </html> 109 </html>
OLDNEW
« no previous file with comments | « no previous file | Source/core/html/shadow/SliderThumbElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698