Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 211403002: DevTools: Support drawing limit value on counters graph (Closed)

Created:
6 years, 9 months ago by alph
Modified:
6 years, 9 months ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Support drawing limit value on counters graph Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -12 lines) Patch
M Source/devtools/front_end/CountersGraph.js View 4 chunks +43 lines, -12 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
alph
ptal
6 years, 9 months ago (2014-03-25 16:14:44 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-25 16:17:16 UTC) #2
yurys
lgtm
6 years, 9 months ago (2014-03-25 16:18:07 UTC) #3
alph
The CQ bit was checked by alph@chromium.org
6 years, 9 months ago (2014-03-25 16:33:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/211403002/1
6 years, 9 months ago (2014-03-25 16:33:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 17:33:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 17:34:00 UTC) #7
alph
The CQ bit was checked by alph@chromium.org
6 years, 9 months ago (2014-03-25 18:29:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/211403002/1
6 years, 9 months ago (2014-03-25 18:29:51 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 18:55:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-25 18:55:43 UTC) #11
alph
The CQ bit was checked by alph@chromium.org
6 years, 9 months ago (2014-03-26 09:55:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/211403002/1
6 years, 9 months ago (2014-03-26 09:55:20 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 10:30:32 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-26 10:30:33 UTC) #15
alph
The CQ bit was checked by alph@chromium.org
6 years, 9 months ago (2014-03-26 11:20:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/211403002/1
6 years, 9 months ago (2014-03-26 11:20:32 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 12:04:41 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-26 12:04:42 UTC) #19
alph
The CQ bit was checked by alph@chromium.org
6 years, 9 months ago (2014-03-27 09:40:53 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/211403002/1
6 years, 9 months ago (2014-03-27 09:41:12 UTC) #21
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 10:27:58 UTC) #22
Message was sent while issue was closed. 
Change committed as 170162

Powered by Google App Engine
This is Rietveld 408576698