Refresh access tokens for TiclInvalidationService

chrome/browser/invalidation/ticl_invalidation_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/invalidation/ticl_invalidation_service.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/invalidation/invalidation_service_util.h"
 #include "chrome/browser/managed_mode/managed_user_service.h"
@@ skipping 240 matching lines @@
       break;
     }
     default: {
       // We have no way to notify the user of this.  Do nothing.
     }
   }
 }
 
 void TiclInvalidationService::OnInvalidatorStateChange(
     syncer::InvalidatorState state) {
-  invalidator_registrar_->UpdateInvalidatorState(state);
+  if (state == syncer::INVALIDATION_CREDENTIALS_REJECTED) {
+    // This may be due to normal OAuth access token expiration.  If so, we must
+    // fetch a new one using our refresh token.  Resetting the invalidator's
+    // access token will not reset the invalidator's exponential backoff, so
+    // it's safe to try to update the token every time we receive this signal.

[akalin, 2013/07/31 22:37:46]

Add comment saying that if the credentials continue to be rejected
invalidator_registrar_ will be notified of that in OnGetTokenFailure.

[akalin, 2013/07/31 22:42:45]

per our discussion, transition to TRANSIENT_ERROR here while the token is being
fetched so that delegates know that the connection is (perhaps temporarily) down

[rlarocque, 2013/07/31 23:00:53]

Done.

+    RequestAccessToken();
+  } else {
+    invalidator_registrar_->UpdateInvalidatorState(state);
+  }
 }
 
 void TiclInvalidationService::OnIncomingInvalidation(
     const syncer::ObjectIdInvalidationMap& invalidation_map) {
   invalidator_registrar_->DispatchInvalidationsToHandlers(invalidation_map);
 }
 
 void TiclInvalidationService::Shutdown() {
   DCHECK(CalledOnValidThread());
   if (IsStarted()) {
@@ skipping 92 matching lines @@
   }
 
   // This service always expects to have a valid invalidator storage.
   // So we must not only clear the old one, but also start a new one.
   invalidator_storage_->Clear();
   invalidator_storage_.reset(new InvalidatorStorage(profile_->GetPrefs()));
   invalidator_storage_->SetInvalidatorClientId(GenerateInvalidatorClientId());
 }
 
 }  // namespace invalidation