Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

Issue 2113943003: SVGLength.value setter should set the value to <number> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Align with review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGLength.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 return target()->value(lengthContext); 131 return target()->value(lengthContext);
132 } 132 }
133 133
134 void SVGLengthTearOff::setValue(float value, ExceptionState& exceptionState) 134 void SVGLengthTearOff::setValue(float value, ExceptionState& exceptionState)
135 { 135 {
136 if (isImmutable()) { 136 if (isImmutable()) {
137 exceptionState.throwDOMException(NoModificationAllowedError, "The attrib ute is read-only."); 137 exceptionState.throwDOMException(NoModificationAllowedError, "The attrib ute is read-only.");
138 return; 138 return;
139 } 139 }
140 140
141 if (target()->isRelative() && !canResolveRelativeUnits(contextElement())) { 141 target()->setValueAsNumber(value);
142 exceptionState.throwDOMException(NotSupportedError, "Could not resolve r elative length.");
143 return;
144 }
145
146 SVGLengthContext lengthContext(contextElement());
147 target()->setValue(value, lengthContext);
148 commitChange(); 142 commitChange();
149 } 143 }
150 144
151 float SVGLengthTearOff::valueInSpecifiedUnits() 145 float SVGLengthTearOff::valueInSpecifiedUnits()
152 { 146 {
153 return target()->valueInSpecifiedUnits(); 147 return target()->valueInSpecifiedUnits();
154 } 148 }
155 149
156 void SVGLengthTearOff::setValueInSpecifiedUnits(float value, ExceptionState& exc eptionState) 150 void SVGLengthTearOff::setValueInSpecifiedUnits(float value, ExceptionState& exc eptionState)
157 { 151 {
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 : SVGPropertyTearOff<SVGLength>(target, contextElement, propertyIsAnimVal, a ttributeName) 229 : SVGPropertyTearOff<SVGLength>(target, contextElement, propertyIsAnimVal, a ttributeName)
236 { 230 {
237 } 231 }
238 232
239 DEFINE_TRACE_WRAPPERS(SVGLengthTearOff) 233 DEFINE_TRACE_WRAPPERS(SVGLengthTearOff)
240 { 234 {
241 visitor->traceWrappers(contextElement()); 235 visitor->traceWrappers(contextElement());
242 } 236 }
243 237
244 } // namespace blink 238 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGLength.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698