🎒 Rework Android resource linting to exclude third_party

Rework Android resource linting to exclude third_party

The existing assumption in the code (that the existense of package name
within android_resource() rules determines whether they should be
linted) turned out to be false.

The new logic does not look at package names, but instead collects all
reference resources, and then excludes any of them that were already
linted by another android_library().

BUG=621774
Committed: https://crrev.com/a12be529fb88039cc3090a83c4fbaaf04e13b144
Cr-Commit-Position: refs/heads/master@{#403687}

[agrieve, 2016-07-01 02:21:11]

Description was changed from

==========
Rework Android resource linting to exclude third_party

The existing assumption in the code (that the existense of package name
within android_resource() rules determines whether they should be
linted) turned out to be false.

The new logic does not look at package names, but instead collects all
reference resources, and then excludes any of them that were already
linted by another android_library().

BUG=621774
==========

to

==========
Rework Android resource linting to exclude third_party

The existing assumption in the code (that the existense of package name
within android_resource() rules determines whether they should be
linted) turned out to be false.

The new logic does not look at package names, but instead collects all
reference resources, and then excludes any of them that were already
linted by another android_library().

BUG=621774
==========

[agrieve, 2016-07-01 02:21:11]

agrieve@chromium.org changed reviewers:
+ mlopatkin@yandex-team.ru

[agrieve, 2016-07-01 02:21:18]

On 2016/07/01 02:21:11, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:mlopatkin@yandex-team.ru

[agrieve, 2016-07-01 02:21:23]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 02:21:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 03:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 03:21:46]

Dry run: This issue passed the CQ dry run.

[mlopatkin, 2016-07-01 12:37:57]

On 2016/07/01 02:21:18, agrieve wrote:
> On 2016/07/01 02:21:11, agrieve wrote:
> > mailto:agrieve@chromium.org changed reviewers:
> > + mailto:mlopatkin@yandex-team.ru

lgtm

[agrieve, 2016-07-04 14:17:53]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-07-04 14:18:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 15:40:33]

Description was changed from

==========
Rework Android resource linting to exclude third_party

The existing assumption in the code (that the existense of package name
within android_resource() rules determines whether they should be
linted) turned out to be false.

The new logic does not look at package names, but instead collects all
reference resources, and then excludes any of them that were already
linted by another android_library().

BUG=621774
==========

to

==========
Rework Android resource linting to exclude third_party

The existing assumption in the code (that the existense of package name
within android_resource() rules determines whether they should be
linted) turned out to be false.

The new logic does not look at package names, but instead collects all
reference resources, and then excludes any of them that were already
linted by another android_library().

BUG=621774
==========

[commit-bot: I haz the power, 2016-07-04 15:40:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-04 15:40:39]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-04 15:42:01]

Description was changed from

==========
Rework Android resource linting to exclude third_party

The existing assumption in the code (that the existense of package name
within android_resource() rules determines whether they should be
linted) turned out to be false.

The new logic does not look at package names, but instead collects all
reference resources, and then excludes any of them that were already
linted by another android_library().

BUG=621774
==========

to

==========
Rework Android resource linting to exclude third_party

The existing assumption in the code (that the existense of package name
within android_resource() rules determines whether they should be
linted) turned out to be false.

The new logic does not look at package names, but instead collects all
reference resources, and then excludes any of them that were already
linted by another android_library().

BUG=621774

Committed: https://crrev.com/a12be529fb88039cc3090a83c4fbaaf04e13b144
Cr-Commit-Position: refs/heads/master@{#403687}
==========

[commit-bot: I haz the power, 2016-07-04 15:42:02]

Patchset 1 (id:??) landed as
https://crrev.com/a12be529fb88039cc3090a83c4fbaaf04e13b144
Cr-Commit-Position: refs/heads/master@{#403687}