third_party/WebKit/public/platform/modules/hyphenation/hyphenation.mojom - Issue 2113933003: Add mojo interface to load hyphenation dictionaries on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/modules/hyphenation/hyphenation.mojom

Issue 2113933003: Add mojo interface to load hyphenation dictionaries on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: jam/eae review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/text/hyphenation/HyphenationMinikin.cpp ('K') | « third_party/WebKit/public/platform/modules/hyphenation/OWNERS ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module blink.mojom;	5 module blink.mojom;

6	6

7 interface MimeRegistry {	7 // Loads hyphenation dictionary.

	8 interface Hyphenation {

	9 // Returns a handle to the raw hyphneation dictionary.

8 [Sync]	10 [Sync]

9 GetMimeTypeFromExtension(string extension) => (string mime_type);	11 OpenDictionary(string locale) => (handle? hyphenation_dictionary_handle);
	dcheng 2016/07/13 02:56:29 Do we need the ? It seems like we always pass back Do we need the ? It seems like we always pass back a handle (even if it's sometimes invalid). Basically, I'm not sure what ? means when you use it with a handle =) kojii 2016/07/13 05:02:29 mojo runtime checks "handle.IsValid()" if "handle" Show quoted text On 2016/07/13 at 02:56:29, dcheng wrote: > Do we need the ? It seems like we always pass back a handle (even if it's sometimes invalid). Basically, I'm not sure what ? means when you use it with a handle =) mojo runtime checks "handle.IsValid()" if "handle". This method returns invalid handle when the dictionary is not found for the locale, and "handle?" solved it for me. Is there better solution?
10 };	12 };

OLD	NEW