content/browser/hyphenation/BUILD.gn - Issue 2113933003: Add mojo interface to load hyphenation dictionaries on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/hyphenation/BUILD.gn

Issue 2113933003: Add mojo interface to load hyphenation dictionaries on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved to content/browser Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//build/config/features.gni")

	6 import("//mojo/public/tools/bindings/mojom.gni")

	7

	8 component("hyphenation") {
	jam 2016/07/12 14:51:12 no need to create a separate component (i.e. .so/. no need to create a separate component (i.e. .so/.dll in component build) for subdirectories in content. If you just want to make sure it doesn't grow dependencies, you can make this directory's DEPS file exclude content. then just add it to private_browser_sources in https://cs.chromium.org/chromium/src/content/content_browser.gypi?rcl=0&l=353 which would also fix the gyp broken sorry I know Brett mentioned otherwise in his email that you can use BUILD files (along with DEPS) to limit the dependencies. We're not yet at the point where we have different source sets for small directories in content/ (or other top level directories other than components) until gyp is removed. tight DEPS rules will accomplish almost the same thing though.
	9 output_name = "hyphenation"

	10

	11 sources = [

	12 "hyphenation_impl.cc",

	13 "hyphenation_impl.h",

	14 ]

	15

	16 defines = [ "HYPHENATION_IMPLEMENTATION" ]

	17

	18 deps = [

	19 "//base",

	20 "//mojo/public/cpp/bindings",

	21 "//third_party/WebKit/public:mojo_bindings",

	22 ]

	23 }

OLD	NEW

« no previous file with comments | « content/browser/BUILD.gn ('k') | content/browser/hyphenation/DEPS » ('j') | content/browser/hyphenation/hyphenation_impl.h » ('J')