Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/polymer/test/build/script_compactor_test.dart

Issue 211393006: Enables codegen support in polymer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/polymer/lib/src/build/script_compactor.dart ('K') | « pkg/polymer/test/build/common.dart ('k') | pkg/polymer/test/prop_attr_reflection_test.dart » ('j') | pkg/template_binding/CHANGELOG.md » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/test/build/script_compactor_test.dart
diff --git a/pkg/polymer/test/build/script_compactor_test.dart b/pkg/polymer/test/build/script_compactor_test.dart
index 2d32a746c4f0e0770aa3c6fe318d6857700dbbe0..78888b6127cbc9b0e0a6b24765a543f610136e15 100644
--- a/pkg/polymer/test/build/script_compactor_test.dart
+++ b/pkg/polymer/test/build/script_compactor_test.dart
@@ -4,16 +4,24 @@
library polymer.test.build.script_compactor_test;
+import 'package:code_transformers/tests.dart' show testingDartSdkDirectory;
import 'package:polymer/src/build/common.dart';
import 'package:polymer/src/build/script_compactor.dart';
+import 'package:smoke/codegen/generator.dart' show DEFAULT_IMPORTS;
import 'package:unittest/compact_vm_config.dart';
+import 'package:unittest/unittest.dart';
import 'common.dart';
void main() {
useCompactVMConfiguration();
- var phases = [[new ScriptCompactor(new TransformOptions())]];
+ var phases = [[new ScriptCompactor(new TransformOptions(),
+ sdkDir: testingDartSdkDirectory)]];
+ group('initializers', () => initializerTests(phases));
+ group('codegen', () => codegenTests(phases));
+}
+initializerTests(phases) {
testPhases('no changes', phases, {
'a|web/test.html': '<!DOCTYPE html><html></html>',
'a|web/test.html.scriptUrls': '[]',
@@ -36,7 +44,10 @@ void main() {
'<!DOCTYPE html><html><head>'
'<script type="application/dart" src="a.dart"></script>',
'a|web/test.html.scriptUrls': '[]',
- 'a|web/a.dart': 'library a;\nmain(){}',
+ 'a|web/a.dart':
+ 'library a;\n'
+ 'import "package:polymer/polymer.dart";\n'
+ 'main(){}',
}, {
'a|web/test.html':
'<!DOCTYPE html><html><head>'
@@ -47,16 +58,122 @@ void main() {
'a|web/test.html_bootstrap.dart':
'''$MAIN_HEADER
import 'a.dart' as i0;
+ ${DEFAULT_IMPORTS.join('\n')}
void main() {
+ useGeneratedCode(new StaticConfiguration(
+ checkedMode: false));
configureForDeployment([
]);
i0.main();
}
'''.replaceAll('\n ', '\n'),
- 'a|web/a.dart': 'library a;\nmain(){}',
+ 'a|web/a.dart':
+ 'library a;\n'
+ 'import "package:polymer/polymer.dart";\n'
+ 'main(){}',
});
+ testPhases('simple initialization', phases, {
+ 'a|web/test.html':
+ '<!DOCTYPE html><html><head>'
+ '<script type="application/dart" src="a.dart"></script>',
+ 'a|web/test.html.scriptUrls': '[]',
+ 'a|web/a.dart':
+ 'library a;\n'
+ 'import "package:polymer/polymer.dart";\n'
+ '@CustomTag("x-foo")\n'
+ 'class XFoo extends PolymerElement {\n'
+ '}\n'
+ 'main(){}',
+ }, {
+ 'a|web/test.html_bootstrap.dart':
+ '''$MAIN_HEADER
+ import 'a.dart' as i0;
+ ${DEFAULT_IMPORTS.join('\n')}
+ import 'a.dart' as smoke_0;
+ import 'package:polymer/polymer.dart' as smoke_1;
+
+ void main() {
+ useGeneratedCode(new StaticConfiguration(
+ checkedMode: false,
+ parents: {
+ smoke_0.XFoo: smoke_1.PolymerElement,
+ },
+ declarations: {
+ smoke_0.XFoo: const {},
+ }));
+ configureForDeployment([
+ () => Polymer.register(\'x-foo\', i0.XFoo),
+ ]);
+ i0.main();
+ }
+ '''.replaceAll('\n ', '\n'),
+ });
+
+ testPhases('use const expressions', phases, {
+ 'a|web/test.html':
+ '<!DOCTYPE html><html><head>'
+ '<script type="application/dart" src="a.dart"></script>',
+ 'a|web/test.html.scriptUrls': '[]',
+ 'a|web/b.dart':
+ 'library a;\n'
+ 'const x = "x";\n',
+ 'a|web/c.dart':
+ 'part of a;\n'
+ 'const dash = "-";\n',
+ 'a|web/a.dart':
+ 'library a;\n'
+ 'import "package:polymer/polymer.dart";\n'
+ 'import "b.dart";\n'
+ 'part "c.dart";\n'
+ 'const letterO = "o";\n'
+ '@CustomTag("\$x\${dash}f\${letterO}o2")\n'
+ 'class XFoo extends PolymerElement {\n'
+ '}\n'
+ 'main(){}',
+ }, {
+ 'a|web/test.html_bootstrap.dart':
+ '''$MAIN_HEADER
+ import 'a.dart' as i0;
+ ${DEFAULT_IMPORTS.join('\n')}
+ import 'a.dart' as smoke_0;
+ import 'package:polymer/polymer.dart' as smoke_1;
+
+ void main() {
+ useGeneratedCode(new StaticConfiguration(
+ checkedMode: false,
+ parents: {
+ smoke_0.XFoo: smoke_1.PolymerElement,
+ },
+ declarations: {
+ smoke_0.XFoo: const {},
+ }));
+ configureForDeployment([
+ () => Polymer.register(\'x-foo2\', i0.XFoo),
+ ]);
+ i0.main();
+ }
+ '''.replaceAll('\n ', '\n'),
+ });
+
+ testPhases('invalid const expression', phases, {
+ 'a|web/test.html':
+ '<!DOCTYPE html><html><head>'
+ '<script type="application/dart" src="a.dart"></script>',
+ 'a|web/test.html.scriptUrls': '[]',
+ 'a|web/a.dart':
+ 'library a;\n'
+ 'import "package:polymer/polymer.dart";\n'
+ '@CustomTag("\${x}-foo")\n' // invalid, x is not defined
+ 'class XFoo extends PolymerElement {\n'
+ '}\n'
+ 'main(){}',
+ }, {}, [
+ 'warning: The parameter to @CustomTag seems to be invalid. '
+ '(web/a.dart 2 11)',
+ ]);
+
testPhases('several scripts', phases, {
'a|web/test.html':
'<!DOCTYPE html><html><head>'
@@ -65,13 +182,17 @@ void main() {
'</div>',
'a|web/test.html.scriptUrls':
'[["a", "web/a.dart"],["a", "web/b.dart"],["a", "web/c.dart"]]',
- 'a|web/d.dart': 'library d;\nmain(){}\n@initMethod mD(){}',
+ 'a|web/d.dart':
+ 'library d;\n'
+ 'import "package:polymer/polymer.dart";\n'
+ 'main(){}\n@initMethod mD(){}',
'a|web/a.dart':
'import "package:polymer/polymer.dart";\n'
'@initMethod mA(){}\n',
'a|web/b.dart':
+ 'import "package:polymer/polymer.dart";\n'
'export "e.dart";\n'
'export "f.dart" show XF1, mF1;\n'
'export "g.dart" hide XG1, mG1;\n'
@@ -80,36 +201,36 @@ void main() {
'a|web/c.dart':
'import "package:polymer/polymer.dart";\n'
- 'part "c_part.dart"\n'
- '@CustomTag("x-c2") class XC2 {}\n',
+ 'part "c_part.dart";\n'
+ '@CustomTag("x-c1") class XC1 extends PolymerElement {}\n',
'a|web/c_part.dart':
- '@CustomTag("x-c1") class XC1 {}\n',
+ '@CustomTag("x-c2") class XC2 extends PolymerElement {}\n',
'a|web/e.dart':
'import "package:polymer/polymer.dart";\n'
- '@CustomTag("x-e") class XE {}\n'
+ '@CustomTag("x-e") class XE extends PolymerElement {}\n'
'@initMethod mE(){}\n',
'a|web/f.dart':
'import "package:polymer/polymer.dart";\n'
- '@CustomTag("x-f1") class XF1 {}\n'
+ '@CustomTag("x-f1") class XF1 extends PolymerElement {}\n'
'@initMethod mF1(){}\n'
- '@CustomTag("x-f2") class XF2 {}\n'
+ '@CustomTag("x-f2") class XF2 extends PolymerElement {}\n'
'@initMethod mF2(){}\n',
'a|web/g.dart':
'import "package:polymer/polymer.dart";\n'
- '@CustomTag("x-g1") class XG1 {}\n'
+ '@CustomTag("x-g1") class XG1 extends PolymerElement {}\n'
'@initMethod mG1(){}\n'
- '@CustomTag("x-g2") class XG2 {}\n'
+ '@CustomTag("x-g2") class XG2 extends PolymerElement {}\n'
'@initMethod mG2(){}\n',
'a|web/h.dart':
'import "package:polymer/polymer.dart";\n'
- '@CustomTag("x-h1") class XH1 {}\n'
+ '@CustomTag("x-h1") class XH1 extends PolymerElement {}\n'
'@initMethod mH1(){}\n'
- '@CustomTag("x-h2") class XH2 {}\n'
+ '@CustomTag("x-h2") class XH2 extends PolymerElement {}\n'
'@initMethod mH2(){}\n',
}, {
'a|web/test.html':
@@ -125,18 +246,43 @@ void main() {
import 'b.dart' as i1;
import 'c.dart' as i2;
import 'd.dart' as i3;
+ ${DEFAULT_IMPORTS.join('\n')}
+ import 'e.dart' as smoke_0;
+ import 'package:polymer/polymer.dart' as smoke_1;
+ import 'f.dart' as smoke_2;
+ import 'g.dart' as smoke_3;
+ import 'h.dart' as smoke_4;
+ import 'c.dart' as smoke_5;
void main() {
+ useGeneratedCode(new StaticConfiguration(
+ checkedMode: false,
+ parents: {
+ smoke_5.XC1: smoke_1.PolymerElement,
+ smoke_5.XC2: smoke_1.PolymerElement,
+ smoke_0.XE: smoke_1.PolymerElement,
+ smoke_2.XF1: smoke_1.PolymerElement,
+ smoke_3.XG2: smoke_1.PolymerElement,
+ smoke_4.XH1: smoke_1.PolymerElement,
+ },
+ declarations: {
+ smoke_5.XC1: const {},
+ smoke_5.XC2: const {},
+ smoke_0.XE: const {},
+ smoke_2.XF1: const {},
+ smoke_3.XG2: const {},
+ smoke_4.XH1: const {},
+ }));
configureForDeployment([
i0.mA,
- () => Polymer.register('x-e', i1.XE),
+ i1.mB,
i1.mE,
- () => Polymer.register('x-f1', i1.XF1),
i1.mF1,
- () => Polymer.register('x-g2', i1.XG2),
i1.mG2,
+ () => Polymer.register('x-e', i1.XE),
+ () => Polymer.register('x-f1', i1.XF1),
+ () => Polymer.register('x-g2', i1.XG2),
() => Polymer.register('x-h1', i1.XH1),
- i1.mB,
() => Polymer.register('x-c1', i2.XC1),
() => Polymer.register('x-c2', i2.XC2),
i3.mD,
@@ -144,5 +290,327 @@ void main() {
i3.main();
}
'''.replaceAll('\n ', '\n'),
+ }, null);
+}
+
+codegenTests(phases) {
+ testPhases('bindings', phases, {
+ 'a|web/test.html':
+ '<!DOCTYPE html><html><body>'
+ '<polymer-element name="foo-bar"><template>'
+ '<div>{{a.node}}</div>'
+ '<div>{{anotherNode}}</div>'
+ '<div class="{{an.attribute}}"></div>'
+ '<a href="path/{{within.an.attribute}}/foo/bar"></a>'
+ '<div data-attribute="{{anotherAttribute}}"></div>'
+ // input and custom-element attributes are treated as 2-way bindings:
+ '<input value="{{this.is.twoWay}}">'
+ '<something-else my-attribute="{{here.too}}"></something-else>'
+ '<div on-click="{{methodName}}"></div>'
+ '<div on-click="{{@read.method}}"></div>'
+ '</template></polymer-element>'
+ '<script type="application/dart" src="a.dart"></script>',
+ 'a|web/test.html.scriptUrls': '[]',
+ 'a|web/a.dart':
+ 'library a;\n'
+ 'import "package:polymer/polymer.dart";\n'
+ 'main(){}',
+ }, {
+ 'a|web/test.html_bootstrap.dart':
+ '''$MAIN_HEADER
+ import 'a.dart' as i0;
+ ${DEFAULT_IMPORTS.join('\n')}
+
+ void main() {
+ useGeneratedCode(new StaticConfiguration(
+ checkedMode: false,
+ getters: {
+ #a: (o) => o.a,
+ #an: (o) => o.an,
+ #anotherAttribute: (o) => o.anotherAttribute,
+ #anotherNode: (o) => o.anotherNode,
+ #attribute: (o) => o.attribute,
+ #here: (o) => o.here,
+ #is: (o) => o.is,
+ #method: (o) => o.method,
+ #methodName: (o) => o.methodName,
+ #node: (o) => o.node,
+ #read: (o) => o.read,
+ #too: (o) => o.too,
+ #twoWay: (o) => o.twoWay,
+ #within: (o) => o.within,
+ },
+ setters: {
+ #too: (o, v) { o.too = v; },
+ #twoWay: (o, v) { o.twoWay = v; },
+ },
+ names: {
+ #a: r'a',
+ #an: r'an',
+ #anotherAttribute: r'anotherAttribute',
+ #anotherNode: r'anotherNode',
+ #attribute: r'attribute',
+ #here: r'here',
+ #is: r'is',
+ #method: r'method',
+ #methodName: r'methodName',
+ #node: r'node',
+ #read: r'read',
+ #too: r'too',
+ #twoWay: r'twoWay',
+ #within: r'within',
+ }));
+ configureForDeployment([
+ ]);
+ i0.main();
+ }
+ '''.replaceAll('\n ', '\n'),
+ 'a|web/a.dart':
+ 'library a;\n'
+ 'import "package:polymer/polymer.dart";\n'
+ 'main(){}',
+ });
+
+ final field1Details = "annotations: const [smoke_1.published]";
+ final field3Details = "isFinal: true, annotations: const [smoke_1.published]";
+ final prop1Details = "kind: PROPERTY, annotations: const [smoke_1.published]";
+ final prop3Details =
+ "kind: PROPERTY, isFinal: true, annotations: const [smoke_1.published]";
+ testPhases('published via annotation', phases, {
+ 'a|web/test.html':
+ '<!DOCTYPE html><html><body>'
+ '<script type="application/dart" src="a.dart"></script>',
+ 'a|web/test.html.scriptUrls': '[]',
+ 'a|web/a.dart':
+ 'library a;\n'
+ 'import "package:polymer/polymer.dart";\n'
+ '@CustomTag("x-foo")\n'
+ 'class XFoo extends PolymerElement {\n'
+ ' @published int field1;\n'
+ ' int field2;\n'
+ ' @published final int field3;\n'
+ ' final int field4;\n'
+ ' @published int get prop1 => 1;\n'
+ ' set prop1(int x) {};\n'
+ ' int get prop2 => 2;\n'
+ ' set prop2(int x) {};\n'
+ ' @published int get prop3 => 3;\n'
+ ' int get prop4 => 4;\n'
+ ' @published int method1() => 1;\n'
+ ' int method2() => 2;\n'
+ '}\n'
+ 'main(){}',
+ }, {
+ 'a|web/test.html_bootstrap.dart':
+ '''$MAIN_HEADER
+ import 'a.dart' as i0;
+ ${DEFAULT_IMPORTS.join('\n')}
+ import 'a.dart' as smoke_0;
+ import 'package:polymer/polymer.dart' as smoke_1;
+
+ void main() {
+ useGeneratedCode(new StaticConfiguration(
+ checkedMode: false,
+ getters: {
+ #field1: (o) => o.field1,
+ #field3: (o) => o.field3,
+ #prop1: (o) => o.prop1,
+ #prop3: (o) => o.prop3,
+ },
+ setters: {
+ #field1: (o, v) { o.field1 = v; },
+ #prop1: (o, v) { o.prop1 = v; },
+ },
+ parents: {
+ smoke_0.XFoo: smoke_1.PolymerElement,
+ },
+ declarations: {
+ smoke_0.XFoo: {
+ #field1: const Declaration(#field1, int, $field1Details),
+ #field3: const Declaration(#field3, int, $field3Details),
+ #prop1: const Declaration(#prop1, int, $prop1Details),
+ #prop3: const Declaration(#prop3, int, $prop3Details),
+ },
+ },
+ names: {
+ #field1: r'field1',
+ #field3: r'field3',
+ #prop1: r'prop1',
+ #prop3: r'prop3',
+ }));
+ configureForDeployment([
+ () => Polymer.register(\'x-foo\', i0.XFoo),
+ ]);
+ i0.main();
+ }
+ '''.replaceAll('\n ', '\n'),
+ });
+
+ testPhases('published via attributes', phases, {
+ 'a|web/test.html':
+ '<!DOCTYPE html><html><body>'
+ '<polymer-element name="x-foo" attributes="field1,prop2">'
+ '</polymer-element>'
+ '<script type="application/dart" src="a.dart"></script>',
+ 'a|web/test.html.scriptUrls': '[]',
+ 'a|web/a.dart':
+ 'library a;\n'
+ 'import "package:polymer/polymer.dart";\n'
+ '@CustomTag("x-foo")\n'
+ 'class XFoo extends PolymerElement {\n'
+ ' int field1;\n'
+ ' int field2;\n'
+ ' int get prop1 => 1;\n'
+ ' set prop1(int x) {};\n'
+ ' int get prop2 => 2;\n'
+ ' set prop2(int x) {};\n'
+ '}\n'
+ 'main(){}',
+ }, {
+ 'a|web/test.html_bootstrap.dart':
+ '''$MAIN_HEADER
+ import 'a.dart' as i0;
+ ${DEFAULT_IMPORTS.join('\n')}
+ import 'a.dart' as smoke_0;
+ import 'package:polymer/polymer.dart' as smoke_1;
+
+ void main() {
+ useGeneratedCode(new StaticConfiguration(
+ checkedMode: false,
+ getters: {
+ #field1: (o) => o.field1,
+ #prop2: (o) => o.prop2,
+ },
+ setters: {
+ #field1: (o, v) { o.field1 = v; },
+ #prop2: (o, v) { o.prop2 = v; },
+ },
+ parents: {
+ smoke_0.XFoo: smoke_1.PolymerElement,
+ },
+ declarations: {
+ smoke_0.XFoo: {
+ #field1: const Declaration(#field1, int),
+ #prop2: const Declaration(#prop2, int, kind: PROPERTY),
+ },
+ },
+ names: {
+ #field1: r'field1',
+ #prop2: r'prop2',
+ }));
+ configureForDeployment([
+ () => Polymer.register(\'x-foo\', i0.XFoo),
+ ]);
+ i0.main();
+ }
+ '''.replaceAll('\n ', '\n'),
+ });
+
+ final fooDetails =
+ "kind: METHOD, annotations: const [const smoke_1.ObserveProperty('x')]";
+ final xChangedDetails = "Function, kind: METHOD";
+ testPhases('ObserveProperty and *Changed methods', phases, {
+ 'a|web/test.html':
+ '<!DOCTYPE html><html><body>'
+ '</polymer-element>'
+ '<script type="application/dart" src="a.dart"></script>',
+ 'a|web/test.html.scriptUrls': '[]',
+ 'a|web/a.dart':
+ 'library a;\n'
+ 'import "package:polymer/polymer.dart";\n'
+ '@CustomTag("x-foo")\n'
+ 'class XFoo extends PolymerElement {\n'
+ ' int x;\n'
+ ' void xChanged() {}\n'
+ ' void attributeChanged() {}\n' // should be excluded
+ ' @ObserveProperty("x")'
+ ' void foo() {}\n'
+ '}\n'
+ 'main(){}',
+ }, {
+ 'a|web/test.html_bootstrap.dart':
+ '''$MAIN_HEADER
+ import 'a.dart' as i0;
+ ${DEFAULT_IMPORTS.join('\n')}
+ import 'a.dart' as smoke_0;
+ import 'package:polymer/polymer.dart' as smoke_1;
+
+ void main() {
+ useGeneratedCode(new StaticConfiguration(
+ checkedMode: false,
+ getters: {
+ #foo: (o) => o.foo,
+ #xChanged: (o) => o.xChanged,
+ },
+ parents: {
+ smoke_0.XFoo: smoke_1.PolymerElement,
+ },
+ declarations: {
+ smoke_0.XFoo: {
+ #foo: const Declaration(#foo, Function, $fooDetails),
+ #xChanged: const Declaration(#xChanged, $xChangedDetails),
+ },
+ },
+ names: {
+ #foo: r'foo',
+ #xChanged: r'xChanged',
+ }));
+ configureForDeployment([
+ () => Polymer.register(\'x-foo\', i0.XFoo),
+ ]);
+ i0.main();
+ }
+ '''.replaceAll('\n ', '\n'),
+ });
+
+ final rcDetails = "#registerCallback, Function, kind: METHOD, isStatic: true";
+ testPhases('register callback is included', phases, {
+ 'a|web/test.html':
+ '<!DOCTYPE html><html><body>'
+ '</polymer-element>'
+ '<script type="application/dart" src="a.dart"></script>',
+ 'a|web/test.html.scriptUrls': '[]',
+ 'a|web/a.dart':
+ 'library a;\n'
+ 'import "package:polymer/polymer.dart";\n'
+ '@CustomTag("x-foo")\n'
+ 'class XFoo extends PolymerElement {\n'
+ ' static registerCallback() {};\n'
+ ' static foo() {};\n'
+ '}\n'
+ 'main(){}',
+ }, {
+ 'a|web/test.html_bootstrap.dart':
+ '''$MAIN_HEADER
+ import 'a.dart' as i0;
+ ${DEFAULT_IMPORTS.join('\n')}
+ import 'a.dart' as smoke_0;
+ import 'package:polymer/polymer.dart' as smoke_1;
+
+ void main() {
+ useGeneratedCode(new StaticConfiguration(
+ checkedMode: false,
+ parents: {
+ smoke_0.XFoo: smoke_1.PolymerElement,
+ },
+ declarations: {
+ smoke_0.XFoo: {
+ #registerCallback: const Declaration($rcDetails),
+ },
+ },
+ staticMethods: {
+ smoke_0.XFoo: {
+ #registerCallback: smoke_0.XFoo.registerCallback,
+ },
+ },
+ names: {
+ #registerCallback: r'registerCallback',
+ }));
+ configureForDeployment([
+ () => Polymer.register(\'x-foo\', i0.XFoo),
+ ]);
+ i0.main();
+ }
+ '''.replaceAll('\n ', '\n'),
});
}
« pkg/polymer/lib/src/build/script_compactor.dart ('K') | « pkg/polymer/test/build/common.dart ('k') | pkg/polymer/test/prop_attr_reflection_test.dart » ('j') | pkg/template_binding/CHANGELOG.md » ('J')

Powered by Google App Engine
This is Rietveld 408576698