Enables codegen support in polymer

pkg/polymer/lib/src/build/linter.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Logic to validate that developers are correctly using Polymer constructs.
 /// This is mainly used to produce warnings for feedback in the editor.
 library polymer.src.build.linter;
 
 import 'dart:async';
 
@@ skipping 196 matching lines @@
       return;
     }
 
     var tagName = node.attributes['name'];
     var extendsTag = node.attributes['extends'];
 
     if (tagName == null) {
       _logger.error('Missing tag name of the custom element. Please include an '
           'attribute like \'name="your-tag-name"\'.',
           span: node.sourceSpan);
-    } else if (!_isCustomTag(tagName)) {
+    } else if (!isCustomTagName(tagName)) {
       _logger.error('Invalid name "$tagName". Custom element names must have '
           'at least one dash and can\'t be any of the following names: '
-          '${_invalidTagNames.keys.join(", ")}.',
+          '${invalidTagNames.keys.join(", ")}.',
           span: node.sourceSpan);
     }
 
-    if (_elements[extendsTag] == null && _isCustomTag(extendsTag)) {
+    if (_elements[extendsTag] == null && isCustomTagName(extendsTag)) {
       _logger.warning('custom element with name "$extendsTag" not found.',
           span: node.sourceSpan);
     }
 
     var attrs = node.attributes['attributes'];
     if (attrs != null) {
       var attrsSpan = node.attributeSpans['attributes'];
 
       // names='a b c' or names='a,b,c'
       // record each name for publishing
-      for (var attr in attrs.split(attrs.contains(',') ? ',' : ' ')) {
-        // remove excess ws
-        attr = attr.trim();
-        if (!_validateCustomAttributeName(attr, attrsSpan)) break;
+      for (var attr in attrs.split(_ATTRIBUTES_REGEX)) {
+        if (!_validateCustomAttributeName(attr.trim(), attrsSpan)) break;
       }
     }
 
     var oldValue = _inPolymerElement;
     _inPolymerElement = true;
     super.visitElement(node);
     _inPolymerElement = oldValue;
   }
 
   /// Checks for multiple Dart script tags in the same page, which is invalid.
@@ skipping 43 matching lines @@
     node.attributes.forEach((name, value) {
       if (name is String && name.startsWith('on')) {
         _validateEventHandler(node, name, value);
       }
     });
 
     // Validate uses of custom-tags
     var nodeTag = node.localName;
     var hasIsAttribute;
     var customTagName;
-    if (_isCustomTag(nodeTag)) {
+    if (isCustomTagName(nodeTag)) {
       // <fancy-button>
       customTagName = nodeTag;
       hasIsAttribute = false;
     } else {
       // <button is="fancy-button">
       customTagName = node.attributes['is'];
       hasIsAttribute = true;
     }
 
     if (customTagName == null || customTagName == 'polymer-element') return;
@@ skipping 67 matching lines @@
 
     if (value.contains('(')) {
       _logger.warning('Invalid event handler body "$value". Declare a method '
           'in your custom element "void handlerName(event, detail, target)" '
           'and use the form $name="handlerName".',
           span: node.attributeSpans[name]);
     }
   }
 }
 
-
-// These names have meaning in SVG or MathML, so they aren't allowed as custom
-// tags.
-var _invalidTagNames = const {
-  'annotation-xml': '',
-  'color-profile': '',
-  'font-face': '',
-  'font-face-src': '',
-  'font-face-uri': '',
-  'font-face-format': '',
-  'font-face-name': '',
-  'missing-glyph': '',
-};
-
-/// Returns true if this is a valid custom element name. See:
-/// <https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/custom/index.html#dfn-custom-element-name>
-bool _isCustomTag(String name) {
-  if (name == null || !name.contains('-')) return false;
-  return !_invalidTagNames.containsKey(name);
-}
-
 const String USE_INIT_DART =
     'To run a polymer application, you need to call "initPolymer". You can '
     'either include a generic script tag that does this for you:'
     '\'<script type="application/dart">export "package:polymer/init.dart";'
     '</script>\' or add your own script tag and call that function. '
     'Make sure the script tag is placed after all HTML imports.';
 
 const String BOOT_JS_DEPRECATED =
     '"boot.js" is now deprecated. Instead, you can initialize your polymer '
     'application by calling "initPolymer()" in your main. If you don\'t have a '
     'main, then you can include our generic main by adding the following '
     'script tag to your page: \'<script type="application/dart">export '
     '"package:polymer/init.dart";</script>\'. Additionally you need to '
     'include: \'<script src="packages/browser/dart.js"></script>\' in the page '
     'too. Make sure these script tags come after all HTML imports.';
+
+final _ATTRIBUTES_REGEX = new RegExp(r'\s|,');

[Jennifer Messerly, 2014/03/27 02:20:32]

maybe comment that this is identical to lib/src/declaration.dart? or could we
move into a shared file somehow?

[Siggi Cherem (dart-lang), 2014/03/28 01:04:26]

Done. added the reference and shared this with the one in script_compactor, but
I rather leave the one in declaration.dart separate for now.