Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 211393005: Convert (nearly) all layout tests to unix line endings (Closed)

Created:
6 years, 9 months ago by enne (OOO)
Modified:
6 years, 8 months ago
Reviewers:
eseidel, ojan
CC:
blink-reviews, dmazzoni, aboxhall, jrobbins
Visibility:
Public.

Description

Convert (nearly) all layout tests to unix line endings Rietveld and the CQ can't apply patches against files with DOS line endings, so convert them all to unix. This skips mhtml tests, which apparently need their carriage returns. These files were found via git grep -I -l $'\r' | grep -v "gif$" | grep -v mhtml (apparently some gif files are marked as text), and then converted by opening them all in vim and doing a :bufdo set ff=unix. The attached code review only includes a sample of two files, as Rietveld is also not happy about attaching 1800 files to a code review. BUG=357373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -151 lines) Patch
M LayoutTests/accessibility/anchor-linked-anonymous-block-crash.html View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html View 1 chunk +143 lines, -143 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
enne (OOO)
This patch will need to be dcommitted. If you really want to see the full ...
6 years, 9 months ago (2014-03-26 00:34:24 UTC) #1
enne (OOO)
eseidel: what do you think of this? I could also land these in chunks of ...
6 years, 8 months ago (2014-03-27 19:14:55 UTC) #2
enne (OOO)
+ojan for opinions/review
6 years, 8 months ago (2014-03-27 20:29:23 UTC) #3
eseidel
So long as we aren't braking intentional testing of \r, etc, i'm all for making ...
6 years, 8 months ago (2014-03-27 21:35:24 UTC) #4
eseidel
I would poke szager or jrobbins before committing (since they both sit near you) and ...
6 years, 8 months ago (2014-03-27 21:37:02 UTC) #5
szager1
On 2014/03/27 21:37:02, eseidel wrote: > I would poke szager or jrobbins before committing (since ...
6 years, 8 months ago (2014-03-27 21:47:59 UTC) #6
Jason Robbins -- corp
On 2014/03/27 21:35:24, eseidel wrote: > Rietveld to be better with these types of patches, ...
6 years, 8 months ago (2014-03-27 22:10:49 UTC) #7
enne (OOO)
6 years, 8 months ago (2014-03-27 22:34:45 UTC) #8
Thanks.  :)

I'll go ahead and land these in chunks of ~100 or so and just TBR them all.

Powered by Google App Engine
This is Rietveld 408576698