Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2113913003: don't use JS_CONST in dart:html (Closed)

Created:
4 years, 5 months ago by Jennifer Messerly
Modified:
4 years, 5 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -69 lines) Patch
M lib/runtime/dart_sdk.js View 5 chunks +8 lines, -10 lines 0 comments Download
M tool/input_sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M tool/sdk_expected_errors.txt View 2 chunks +54 lines, -54 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
4 years, 5 months ago (2016-07-01 17:47:18 UTC) #2
Jacob
lgtm
4 years, 5 months ago (2016-07-01 17:49:44 UTC) #3
Jacob
lgtm
4 years, 5 months ago (2016-07-01 17:49:46 UTC) #4
Jennifer Messerly
4 years, 5 months ago (2016-07-01 17:53:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a5a70757c1c0ce0325c2e54798fec581dbc4c3a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698