Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 2113873002: Add PrivacyMode QUIC pooling unittest. (Closed)

Created:
4 years, 5 months ago by Bence
Modified:
4 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PrivacyMode QUIC pooling unittest. Add QUIC unittest to make sure QuicStreamFactory does not pool sessions if PrivacyMode differs. Committed: https://crrev.com/47eba7dd314659e05a623f41ee658ba3d63e6f26 Cr-Commit-Position: refs/heads/master@{#403376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
M net/quic/quic_stream_factory_test.cc View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Bence
Ryan: PTAL. Thanks.
4 years, 5 months ago (2016-07-01 00:30:35 UTC) #2
Ryan Hamilton
lgtm
4 years, 5 months ago (2016-07-01 00:36:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113873002/1
4 years, 5 months ago (2016-07-01 00:39:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 00:43:54 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 00:43:55 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 00:46:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47eba7dd314659e05a623f41ee658ba3d63e6f26
Cr-Commit-Position: refs/heads/master@{#403376}

Powered by Google App Engine
This is Rietveld 408576698