Issue 211383003: Debugger improvements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 211383003: Debugger improvements (Closed)

Created:
6 years, 9 months ago by robertphillips

Modified:
6 years, 9 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Debugger improvements This CL: improves the 'SaveAs' functionality allows switching between # and offset indexing in the command list minor nit cleanup Committed: http://code.google.com/p/skia/source/detail?r=13950

Patch Set 1 #

Patch Set 2 : Fixed CL collision #

Patch Set 3 : Fix Mac 10.8 compilation issue #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+241 lines, -143 lines)			Patch
M	debugger/QT/SkDebuggerGUI.h	View	1	4 chunks	+8 lines, -1 line	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View	1 2	9 chunks	+34 lines, -16 lines	0 comments	Download
M	debugger/QT/SkListWidget.h	View	1	1 chunk	+19 lines, -6 lines	0 comments	Download
M	debugger/QT/SkListWidget.cpp	View	1	3 chunks	+12 lines, -11 lines	0 comments	Download
M	debugger/SkDebugger.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	debugger/SkDebugger.cpp	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download
M	src/utils/debugger/SkDebugCanvas.h	View	1	4 chunks	+20 lines, -0 lines	0 comments	Download
M	src/utils/debugger/SkDebugCanvas.cpp	View	1	9 chunks	+36 lines, -24 lines	0 comments	Download
M	src/utils/debugger/SkDrawCommand.h	View	1	8 chunks	+15 lines, -11 lines	0 comments	Download
M	src/utils/debugger/SkDrawCommand.cpp	View	1	46 chunks	+73 lines, -74 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 9 months ago (2014-03-25 22:09:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/211383003/240001

6 years, 9 months ago (2014-03-25 22:09:17 UTC) #4

Message was sent while issue was closed.

Change committed as 13950

Expand Messages | Collapse Messages