Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2113803003: Gn analyze bug (Closed)

Created:
4 years, 5 months ago by cfroussios
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gn analyze bug gn check does not ignore illegal includes when they are hidden behind preprocessor conditions. In the first revision, there is an #error inside the body. This demonstrates which bots should actually fail. In the second revision, I include a header without depending on the appropriate target. The preprocessor condition is the same, therefore it should affect the same bots as before. However, bots that should be unaffected also fail. BUG=625122

Patch Set 1 : Preprocessor error behind flag #

Patch Set 2 : gn check error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/app/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
cfroussios
Description was changed from ========== Gn analyze bug BUG= ========== to ========== Gn analyze bug ...
4 years, 5 months ago (2016-07-01 11:51:07 UTC) #1
cfroussios
Description was changed from ========== Gn analyze bug gn check does not ignore illegal includes ...
4 years, 5 months ago (2016-07-01 11:51:42 UTC) #2
cfroussios
4 years, 5 months ago (2016-07-01 12:07:16 UTC) #3
Description was changed from

==========
Gn analyze bug

gn check does not ignore illegal includes when they are
 hidden behind preprocessor conditions.

In the first revision, there is an #error inside the body.
 This demonstrates which bots should actually fail.

In the second revision, I include a header without depending
 on the appropriate target. The preprocessor condition is
 the same, therefore it should affect the same bots as before.

However, bots that should be unaffected also fail.

BUG=
==========

to

==========
Gn analyze bug

gn check does not ignore illegal includes when they are
 hidden behind preprocessor conditions.

In the first revision, there is an #error inside the body.
 This demonstrates which bots should actually fail.

In the second revision, I include a header without depending
 on the appropriate target. The preprocessor condition is
 the same, therefore it should affect the same bots as before.

However, bots that should be unaffected also fail.

BUG=625122
==========

Powered by Google App Engine
This is Rietveld 408576698