Chromium Code Reviews
DescriptionGn analyze bug
gn check does not ignore illegal includes when they are
hidden behind preprocessor conditions.
In the first revision, there is an #error inside the body.
This demonstrates which bots should actually fail.
In the second revision, I include a header without depending
on the appropriate target. The preprocessor condition is
the same, therefore it should affect the same bots as before.
However, bots that should be unaffected also fail.
BUG=625122
Patch Set 1 : Preprocessor error behind flag #Patch Set 2 : gn check error #
Messages
Total messages: 3 (3 generated)
|
||||||||||||||||||||||||||||