Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/sfnt/SkOTTable_name.cpp

Issue 21138005: Fix invalid comparison between int16 and int16be in name table code. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/sfnt/SkOTTable_name.cpp
===================================================================
--- src/sfnt/SkOTTable_name.cpp (revision 10422)
+++ src/sfnt/SkOTTable_name.cpp (working copy)
@@ -495,7 +495,7 @@
const SkOTTableName::Format1Ext* format1ext =
SkTAfter<const SkOTTableName::Format1Ext>(nameRecords, nameRecordsCount);
- if (languageTagRecordIndex < format1ext->langTagCount) {
+ if (languageTagRecordIndex < SkEndian_SwapBE16(format1ext->langTagCount)) {
const SkOTTableName::Format1Ext::LangTagRecord* languageTagRecord =
SkTAfter<const SkOTTableName::Format1Ext::LangTagRecord>(format1ext);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698