chrome/renderer/media/cast_session.cc - Issue 2113783002: Refactoring: Merge VideoSenderConfig and AudioSenderConfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/media/cast_session.cc

Issue 2113783002: Refactoring: Merge VideoSenderConfig and AudioSenderConfig. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments and rebased. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/cast_streaming_native_handler.cc ('K') | « chrome/renderer/media/cast_session.h ('k') | chrome/renderer/media/cast_session_delegate.h » ('j') | media/cast/receiver/frame_receiver.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/media/cast_session.cc

diff --git a/chrome/renderer/media/cast_session.cc b/chrome/renderer/media/cast_session.cc

index 2689bd1117872b9b4237c2ec7a290212e031b091..48ceb1b74f000100018813c185afd3420f204d6b 100644

--- a/chrome/renderer/media/cast_session.cc

+++ b/chrome/renderer/media/cast_session.cc

@@ -54,7 +54,7 @@ CastSession::~CastSession() {

CHECK(io_task_runner_->DeleteSoon(FROM_HERE, delegate_.release()));

}

-void CastSession::StartAudio(const media::cast::AudioSenderConfig& config,

+void CastSession::StartAudio(const media::cast::FrameSenderConfig& config,

const AudioFrameInputAvailableCallback& callback,

const ErrorCallback& error_callback) {

DCHECK(content::RenderThread::Get());

@@ -68,7 +68,7 @@ void CastSession::StartAudio(const media::cast::AudioSenderConfig& config,

media::BindToCurrentLoop(error_callback)));

}

-void CastSession::StartVideo(const media::cast::VideoSenderConfig& config,

+void CastSession::StartVideo(const media::cast::FrameSenderConfig& config,

const VideoFrameInputAvailableCallback& callback,

const ErrorCallback& error_callback) {

DCHECK(content::RenderThread::Get());