chrome/renderer/media/cast_session_delegate.cc - Issue 2113783002: Refactoring: Merge VideoSenderConfig and AudioSenderConfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/media/cast_session_delegate.cc

Issue 2113783002: Refactoring: Merge VideoSenderConfig and AudioSenderConfig. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed mek's comment. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/media/cast_session_delegate.h ('k') | chrome/test/data/extensions/api_test/cast_streaming/rtp_stream_error.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/media/cast_session_delegate.cc

diff --git a/chrome/renderer/media/cast_session_delegate.cc b/chrome/renderer/media/cast_session_delegate.cc

index eddf8e34102b03abf1c55bf63c17a8ce2ac4221c..7645619c20fe9b74fc12b5e575d15afe9aa0f988 100644

--- a/chrome/renderer/media/cast_session_delegate.cc

+++ b/chrome/renderer/media/cast_session_delegate.cc

@@ -29,10 +29,9 @@

#include "media/cast/net/cast_transport.h"

#include "media/cast/net/cast_transport_config.h"

-using media::cast::AudioSenderConfig;

using media::cast::CastEnvironment;

using media::cast::CastSender;

-using media::cast::VideoSenderConfig;

+using media::cast::FrameSenderConfig;

static base::LazyInstance<CastThreads> g_cast_threads =

LAZY_INSTANCE_INITIALIZER;

@@ -117,7 +116,7 @@ CastSessionDelegate::~CastSessionDelegate() {

}

void CastSessionDelegate::StartAudio(

- const AudioSenderConfig& config,

+ const FrameSenderConfig& config,

const AudioFrameInputAvailableCallback& callback,

const ErrorCallback& error_callback) {

DCHECK(io_task_runner_->BelongsToCurrentThread());

@@ -135,7 +134,7 @@ void CastSessionDelegate::StartAudio(

}

void CastSessionDelegate::StartVideo(

- const VideoSenderConfig& config,

+ const FrameSenderConfig& config,

const VideoFrameInputAvailableCallback& callback,

const ErrorCallback& error_callback,

const media::cast::CreateVideoEncodeAcceleratorCallback& create_vea_cb,