Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: media/cast/sender/external_video_encoder.cc

Issue 2113783002: Refactoring: Merge VideoSenderConfig and AudioSenderConfig. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/sender/external_video_encoder.cc
diff --git a/media/cast/sender/external_video_encoder.cc b/media/cast/sender/external_video_encoder.cc
index ce55791acdb20034cebda2bed3a81e2bf0746f6d..840019c9cf2a9ff43404398459e24a2d1d4348b7 100644
--- a/media/cast/sender/external_video_encoder.cc
+++ b/media/cast/sender/external_video_encoder.cc
@@ -87,7 +87,7 @@ class ExternalVideoEncoder::VEAClientImpl
const scoped_refptr<CastEnvironment>& cast_environment,
const scoped_refptr<base::SingleThreadTaskRunner>& encoder_task_runner,
std::unique_ptr<media::VideoEncodeAccelerator> vea,
- int max_frame_rate,
+ double max_frame_rate,
const StatusChangeCallback& status_change_cb,
const CreateVideoEncodeMemoryCallback& create_video_encode_memory_cb)
: cast_environment_(cast_environment),
@@ -138,8 +138,8 @@ class ExternalVideoEncoder::VEAClientImpl
DCHECK(task_runner_->RunsTasksOnCurrentThread());
requested_bit_rate_ = bit_rate;
- video_encode_accelerator_->RequestEncodingParametersChange(bit_rate,
- max_frame_rate_);
+ video_encode_accelerator_->RequestEncodingParametersChange(
+ bit_rate, static_cast<uint32_t>(max_frame_rate_ + 0.5));
}
// The destruction call back of the copied video frame to free its use of
@@ -536,7 +536,7 @@ class ExternalVideoEncoder::VEAClientImpl
const scoped_refptr<CastEnvironment> cast_environment_;
const scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
- const int max_frame_rate_;
+ const double max_frame_rate_;
const StatusChangeCallback status_change_cb_; // Must be run on MAIN thread.
const CreateVideoEncodeMemoryCallback create_video_encode_memory_cb_;
std::unique_ptr<media::VideoEncodeAccelerator> video_encode_accelerator_;
@@ -590,7 +590,7 @@ class ExternalVideoEncoder::VEAClientImpl
};
// static
-bool ExternalVideoEncoder::IsSupported(const VideoSenderConfig& video_config) {
+bool ExternalVideoEncoder::IsSupported(const FrameSenderConfig& video_config) {
if (video_config.codec != CODEC_VIDEO_VP8 &&
video_config.codec != CODEC_VIDEO_H264)
return false;
@@ -604,7 +604,7 @@ bool ExternalVideoEncoder::IsSupported(const VideoSenderConfig& video_config) {
ExternalVideoEncoder::ExternalVideoEncoder(
const scoped_refptr<CastEnvironment>& cast_environment,
- const VideoSenderConfig& video_config,
+ const FrameSenderConfig& video_config,
const gfx::Size& frame_size,
FrameId first_frame_id,
const StatusChangeCallback& status_change_cb,
@@ -613,7 +613,7 @@ ExternalVideoEncoder::ExternalVideoEncoder(
: cast_environment_(cast_environment),
create_video_encode_memory_cb_(create_video_encode_memory_cb),
frame_size_(frame_size),
- bit_rate_(video_config.start_bitrate),
+ bit_rate_(video_config.codec_specific_params.start_bitrate),
key_frame_requested_(false),
weak_factory_(this) {
DCHECK(cast_environment_->CurrentlyOn(CastEnvironment::MAIN));
@@ -673,7 +673,7 @@ void ExternalVideoEncoder::GenerateKeyFrame() {
}
void ExternalVideoEncoder::OnCreateVideoEncodeAccelerator(
- const VideoSenderConfig& video_config,
+ const FrameSenderConfig& video_config,
FrameId first_frame_id,
const StatusChangeCallback& status_change_cb,
scoped_refptr<base::SingleThreadTaskRunner> encoder_task_runner,
@@ -725,7 +725,7 @@ void ExternalVideoEncoder::OnCreateVideoEncodeAccelerator(
SizeAdaptableExternalVideoEncoder::SizeAdaptableExternalVideoEncoder(
const scoped_refptr<CastEnvironment>& cast_environment,
- const VideoSenderConfig& video_config,
+ const FrameSenderConfig& video_config,
const StatusChangeCallback& status_change_cb,
const CreateVideoEncodeAcceleratorCallback& create_vea_cb,
const CreateVideoEncodeMemoryCallback& create_video_encode_memory_cb)

Powered by Google App Engine
This is Rietveld 408576698