Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: tools/metrics/actions/actions.xml

Issue 2113743002: Add instrumentation for password autofill and Credential Manager API user flows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_form_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index 89300f4113597da47c4d6beb9726ff5b7648085b..80b5019ecd611e2f799d207d29e8ab6307a71481 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -2931,6 +2931,26 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description>
</action>
+<action name="CredentialManager_AccountChooser_Accepted">
+ <owner>vasilii@chromium.org</owner>
+ <description>
+ The user chose a credential via the account chooser.
+ </description>
+</action>
+
+<action name="CredentialManager_AccountChooser_Dismissed">
+ <owner>vasilii@chromium.org</owner>
+ <description>The user dismissed the account chooser.</description>
+</action>
+
+<action name="CredentialManager_Autosignin">
+ <owner>vasilii@chromium.org</owner>
+ <description>
+ The website tried to automatically sign the user in and got a credential
+ back from the browser.
+ </description>
+</action>
+
<action name="CriticalNotificationShown">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
@@ -12176,6 +12196,21 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description>
</action>
+<action name="PasswordManager_Autofilled">
+ <owner>vasilii@chromium.org</owner>
+ <description>Username/password were autofilled on pageload.</description>
+</action>
+
+<action name="PasswordManager_ChoseSubdomainPassword">
+ <owner>vasilii@chromium.org</owner>
+ <description>
+ The user submitted a form with an existing credential saved for another
+ subdomain. For example, the user might have signed in on
+ https://accounts.spotify.com using a credential previously saved for
+ https://play.spotify.com.
+ </description>
+</action>
+
<action name="PasswordManager_Disabled">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
@@ -12186,6 +12221,43 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description>
</action>
+<action name="PasswordManager_LoggedInWithNewPassword">
+ <owner>vasilii@chromium.org</owner>
+ <description>
+ The user tried to log in with an existing (possibly for another subdomain)
+ credential but different password.
+ </description>
+</action>
+
+<action name="PasswordManager_LoggedInWithNewUsername">
+ <owner>vasilii@chromium.org</owner>
+ <description>
+ The user tried to log in with a completely new (possibly auto generated)
+ credential.
+ </description>
+</action>
+
+<action name="PasswordManager_LoginFailed">
+ <owner>vasilii@chromium.org</owner>
+ <description>
+ The user submitted a password form, but the website appeared to reject
Ilya Sherman 2016/07/14 23:40:26 nit: Please remove the extra leading whitespace on
vasilii 2016/07/15 09:49:31 Done.
+ the credentials. This action reflects the password manager component's
+ logic for whether or not to offer to save a password. At the time of
+ writing, failure means that either the form submission was canceled with a
+ failure message, or the form submission succeeded, but the user was directed
+ back to a page that still contained a login form.
+ </description>
+</action>
+
+<action name="PasswordManager_LoginPassed">
+ <owner>vasilii@chromium.org</owner>
+ <description>
+ The user submitted a password form, the website appeared to accept the
Ilya Sherman 2016/07/14 23:40:26 nit: s/form, the/form and the
vasilii 2016/07/15 09:49:31 Done.
+ credentials. This action reflects the password manager component's logic
+ for whether or not to offer to save a password.
+ </description>
+</action>
+
<action name="PasswordManager_RemovePasswordException">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
@@ -12214,6 +12286,15 @@ should be able to be added at any place in this file.
</description>
</action>
+<action name="PasswordManager_UsedNonDefaultUsername">
+ <owner>vasilii@chromium.org</owner>
+ <description>
+ The user logged in with an existing credential other than the default one.
+ This results in the default credential being updated, to the credential that
+ the user most recently logged in with.
+ </description>
+</action>
+
<action name="Paste">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
« no previous file with comments | « components/password_manager/core/browser/password_form_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698