Add instrumentation for password autofill and Credential Manager API user flows.

tools/metrics/actions/actions.xml

Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index 896d6c0982de7c6b85577e735a6c898ee9ce8c11..bebfdec4a64ed5172ad3c6ca60ee25a9c8eb1806 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -2859,6 +2859,26 @@ should be able to be added at any place in this file.
   <description>Please enter the description of this user action.</description>
 </action>
 
+<action name="CredentialManager_AccountChooser_Accepted">
+  <owner>vasilii@chromium.org</owner>
+  <description>
+    The user chose a credential via the account chooser.
+  </description>
+</action>
+
+<action name="CredentialManager_AccountChooser_Dismissed">
+  <owner>vasilii@chromium.org</owner>
+  <description>The user dismissed the account chooser.</description>
+</action>
+
+<action name="CredentialManager_Autosignin">
+  <owner>vasilii@chromium.org</owner>
+  <description>
+    The website tried to automatically sign the user in and got a credential
+    back from the browser.
+  </description>
+</action>
+
 <action name="CriticalNotificationShown">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>
@@ -12078,6 +12098,19 @@ should be able to be added at any place in this file.
   <description>Please enter the description of this user action.</description>
 </action>
 
+<action name="PasswordManager_Autofilled">
+  <owner>vasilii@chromium.org</owner>
+  <description>Username/password were autofilled on pageload.</description>
+</action>
+
+<action name="PasswordManager_ChosePSL">

[Ilya Sherman, 2016/07/07 05:01:48]

Please update the action name to also use something clearer/less jargony than
"PSL".

[vasilii, 2016/07/14 14:55:08]

Done.

+  <owner>vasilii@chromium.org</owner>
+  <description>
+    The user submits a form with an existing credential saved for another

[Ilya Sherman, 2016/07/07 05:01:48]

nit: s/submit/submitted

[vasilii, 2016/07/14 14:55:08]

Done.

+    subdomain.

[Ilya Sherman, 2016/07/07 05:01:49]

nit: I think an example user flow might be helpful here, i.e. "For example, the
user might have signed in on https://accounts.spotify.com using a credential
previously saved for https://play.spotify.com."

[vasilii, 2016/07/14 14:55:08]

Done.

+  </description>
+</action>
+
 <action name="PasswordManager_Disabled">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>
@@ -12088,6 +12121,22 @@ should be able to be added at any place in this file.
   <description>Please enter the description of this user action.</description>
 </action>
 
+<action name="PasswordManager_LoggedInWithNewPassword">
+  <owner>vasilii@chromium.org</owner>
+  <description>
+    The user tries to log in with an existing (PSL or not) credential but

[Ilya Sherman, 2016/07/07 05:01:48]

nit: Here as well, please clarify the meaning of "PSL" for those readers not
intimately familiar with this feature.

[Ilya Sherman, 2016/07/07 05:01:49]

nit: s/tries/tried

[vasilii, 2016/07/14 14:55:08]

Done.

[vasilii, 2016/07/14 14:55:08]

Done.

+    different password.
+  </description>
+</action>
+
+<action name="PasswordManager_LoggedInWithNewUsername">
+  <owner>vasilii@chromium.org</owner>
+  <description>
+    The user tries to log in with a completely new (possibly auto generated)

[Ilya Sherman, 2016/07/07 05:01:48]

nit: s/tries/tried

[vasilii, 2016/07/14 14:55:08]

Done.

+    credential.
+  </description>
+</action>
+
 <action name="PasswordManager_RemovePasswordException">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>
@@ -12098,6 +12147,20 @@ should be able to be added at any place in this file.
   <description>Please enter the description of this user action.</description>
 </action>
 
+<action name="PasswordManager_SubmitFailed">

[Ilya Sherman, 2016/07/07 05:01:49]

nit: I think this metric is really trying to measure "LoginFailed" vs
"LoginSucceeded".  Is that right?  The current name makes me think it's trying
to measure something technical about form events, which I'm realizing is
probably not your intention.

[vasilii, 2016/07/14 14:55:08]

Done.

+  <owner>vasilii@chromium.org</owner>
+  <description>
+    Password form submitted but the password doesn't seem right.

[Ilya Sherman, 2016/07/07 05:01:48]

This description is quite vague.  Imagine that you read "The user typed a URL
into the omnibox, but the URL didn't seem right".  What would you think "didn't
seem right" meant?  Wasn't a URL?  Was a commonly typo-ed URL?  Was a malicious
URL?

I'd suggest something like: "The user submitted a password form, and the form
submission was cancelled with a failure event.  This typically indicates that
the provided login details were incorrect." (Note: Only write "The user" if this
metric is gated on a user action.)

Also, I'm not sure -- does this metric actually cover the case where the form
submission succeeds (in terms of the HTTP POST going through), but the user is
bounced back to a login page showing a warning?  That is, is this metric really
measuring what the password manager "thinks" of the form submission?  If so, I'd
write the description somewhat differently: "The user submitted a password form,
but the website appeared to reject the credentials.  This action reflects the
password manager component's logic for whether or not to offer to save a
password.  At the time of writing, failure means that either the form submission
was canceled with a failure message, or the form submission succeeded, but the
user was directed back to a page that still contained a login form."

(Or, something along those lines, but clearer/more accurate.) =)

[vasilii, 2016/07/14 14:55:08]

Done.

+  </description>
+</action>
+
+<action name="PasswordManager_SubmitPassed">

[Ilya Sherman, 2016/07/07 05:01:48]

(Ditto)

[vasilii, 2016/07/14 14:55:08]

Done.

+  <owner>vasilii@chromium.org</owner>
+  <description>
+    Password form submitted successfully and login form disappeared.

[Ilya Sherman, 2016/07/07 05:01:48]

Please similarly clarify this description.

[vasilii, 2016/07/14 14:55:08]

Done.

+  </description>
+</action>
+
 <action name="PasswordManager_SyncCredentialShown">
   <owner>gcasto@chromium.org</owner>
   <owner>vabr@chromium.org</owner>
@@ -12116,6 +12179,15 @@ should be able to be added at any place in this file.
   </description>
 </action>
 
+<action name="PasswordManager_UseNonDefaultUsername">

[Ilya Sherman, 2016/07/07 05:01:49]

nit: s/Use/Used

[vasilii, 2016/07/14 14:55:08]

Done.

+  <owner>vasilii@chromium.org</owner>
+  <description>
+    The user logged in with a credential other than the default one.  This

[Ilya Sherman, 2016/07/07 05:01:48]

Is this, specifically, a previously-saved credential?  Or any credential, even
one that was not previously saved?  (A credential that was not previously saved,
presumably, cannot be set as default until it is saved, and it is not saved
until the user accepts Chrome's prompt to save it.  So, this description doesn't
quite make sense in its current form.)

[vasilii, 2016/07/14 14:55:08]

Done.

+    results in the default credential being updated, to the credential that the
+    user most recently logged in with.
+  </description>
+</action>
+
 <action name="Paste">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>