components/password_manager/content/browser/credential_manager_impl.cc - Issue 2113743002: Add instrumentation for password autofill and Credential Manager API user flows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_impl.cc

Issue 2113743002: Add instrumentation for password autofill and Credential Manager API user flows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update the descriptions Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/password_manager/core/browser/credential_manager_pending_request_task.cc » ('j') | components/password_manager/core/browser/password_form_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_impl.cc

diff --git a/components/password_manager/content/browser/credential_manager_impl.cc b/components/password_manager/content/browser/credential_manager_impl.cc

index ba0cf7dda227d84da9820bc3aaca0a94be96ac08..ef2a1e9103f0bd6a78d73f094ffc7a4174f119c7 100644

--- a/components/password_manager/content/browser/credential_manager_impl.cc

+++ b/components/password_manager/content/browser/credential_manager_impl.cc

@@ -7,6 +7,7 @@

#include <utility>

#include "base/bind.h"

+#include "base/metrics/user_metrics.h"

#include "base/strings/string16.h"

#include "base/strings/utf_string_conversions.h"

#include "components/autofill/core/common/password_form.h"

@@ -250,6 +251,11 @@ void CredentialManagerImpl::SendPasswordForm(

store->UpdateLogin(update_form);

}

+ base::RecordAction(

+ base::UserMetricsAction("CredentialManager_AccountChooser_Accepted"));

+ } else {

+ base::RecordAction(

+ base::UserMetricsAction("CredentialManager_AccountChooser_Dismissed"));

}

SendCredential(send_callback, info);

}