Add instrumentation for password autofill and Credential Manager API user flows.

tools/metrics/actions/actions.xml

Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index 896d6c0982de7c6b85577e735a6c898ee9ce8c11..c3158b391238137bf4025b636ad6046599ca9e49 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -2859,6 +2859,28 @@ should be able to be added at any place in this file.
   <description>Please enter the description of this user action.</description>
 </action>
 
+<action name="Credential_Manager_AccountChooser_Click">

[Ilya Sherman, 2016/07/01 17:59:54]

Optional nit: I'd write "CredentialManager" as a single unit (here and
throughout)

[Ilya Sherman, 2016/07/01 17:59:55]

Optional nit: I'd replace "Click" with something like "AcceptedCredential" (or
"SelectedCredential" -- in the omnibox world, "selected" and "accepted" have
very specific meanings, but I'm not sure whether they generalize outside of that
specific context)

[vasilii, 2016/07/04 20:10:41]

Done. Shortened, so it fits one line in the code.

[vasilii, 2016/07/04 20:10:41]

Done.

+  <owner>vasilii@chromium.org</owner>
+  <description>User chose a credential via the account chooser</description>

[Ilya Sherman, 2016/07/01 17:59:54]

nit: Please end the sentence with a period (and please apply this change through
the CL, as needed).

[Ilya Sherman, 2016/07/01 17:59:54]

nit: s/User/The user (and please apply this change through the CL, as needed)

[vasilii, 2016/07/04 20:10:41]

Done.

[vasilii, 2016/07/04 20:10:41]

Done.

+</action>
+
+<action name="Credential_Manager_AccountChooser_Dismiss">

[Ilya Sherman, 2016/07/01 17:59:55]

Optional nit: I'd name this "Dismissed" rather than "Dismiss" -- I think user
action names often sound better when written in the past tense.

[vasilii, 2016/07/04 20:10:41]

Done.

+  <owner>vasilii@chromium.org</owner>
+  <description>User dismissed the account chooser</description>
+</action>
+
+<action name="Credential_Manager_Autosignin">
+  <owner>vasilii@chromium.org</owner>
+  <description>Try to automatically sign user in</description>

[Ilya Sherman, 2016/07/01 17:59:54]

I *think* this description means "The website tried to automatically sign the
user in".  Or, does it mean that the website tried to do so, and the user had
already consented?  What does the word "try" mean, i.e. what are the possible
failure cases?  Would it make more sense to only log an autosignin metric in
case of success, or some specific failure case?

Also, this doesn't seem like it is really a user action per se.  If a website
spams the autosignin API, will we just generate an arbitrary number of these
user actions?

[vasilii, 2016/07/04 20:10:41]

I changed the description. A failure case is the the credential is obsolete.
It's super rare as it occurs only when cookies expired and other 100 privacy
conditions are satisfied.

+</action>
+
+<action name="Credential_Manager_Get_EmptyStore">
+  <owner>vasilii@chromium.org</owner>
+  <description>
+    A site requested a credential but the store is empty

[Ilya Sherman, 2016/07/01 17:59:55]

This also doesn't really seem like a user action.  What's the context for
recording this?

[vasilii, 2016/07/04 20:10:41]

Removed.

+  </description>
+</action>
+
 <action name="CriticalNotificationShown">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>
@@ -12078,6 +12100,26 @@ should be able to be added at any place in this file.
   <description>Please enter the description of this user action.</description>
 </action>
 
+<action name="PasswordManager_Autofilled">
+  <owner>vasilii@chromium.org</owner>
+  <description>Username/password were autofilled</description>

[Ilya Sherman, 2016/07/01 17:59:55]

Please expand this description.  Is this just on pageload?  Or, if the user
selects an alternate username/password pair and autofills that, is that recorded
as well?

[vasilii, 2016/07/04 20:10:40]

Done.

+</action>
+
+<action name="PasswordManager_ChooseNonDefault">

[Ilya Sherman, 2016/07/01 17:59:54]

Optional nit: s/Choose/Chose

[vasilii, 2016/07/04 20:10:40]

Done.

+  <owner>vasilii@chromium.org</owner>
+  <description>
+    An existing credential becomes the new default one for the page after user
+    logged in with it

[Ilya Sherman, 2016/07/01 17:59:54]

This description doesn't obviously match the action name.  Perhaps a name like
"LoggedInWithNonDefaultCredential" would be clearer?  You could probably come up
with something shorter, but still clear.

Additionally, I'd update the action description to more clearly highlight the
*user* action.  For example, something like "The user logged in with a
credential other than the default one.  This results in the default credential
being updated, to the credential that the user most recently logged in with." 
By the way, it's not quite clear to me: is this only logged if the user has
already saved the alternate credential / only logged if the alternate credential
ends up being saved / logged regardless of whether the alternate credential is
saved?  I think my suggested description is none of those, so it's not quite
accurate -- please update it to clarify.

By the way, am I right to understand that "non-default credential" really means
"non-default username"?  If so, I think it might be better to use that wording,
as it's clearer.

[vasilii, 2016/07/04 20:10:40]

Done. Alternate credential has already been saved.

+  </description>
+</action>
+
+<action name="PasswordManager_ChoosePSL">

[Ilya Sherman, 2016/07/01 17:59:55]

Optional nit: s/Choose/Chose

[vasilii, 2016/07/04 20:10:41]

Done.

+  <owner>vasilii@chromium.org</owner>
+  <description>
+    User tries to log in with an existing PSL-match credential

[Ilya Sherman, 2016/07/01 17:59:54]

"PSL" is pretty jargony, i.e. is hard for someone outside of the team to
understand.  Is there a way to write this description in a way that would be
clear to a statistician working primarily on, say, Chrome Translate integration?

[Ilya Sherman, 2016/07/01 17:59:55]

What does "tries to" mean here?  That is, what are the failure modes?  Is this
essentially recorded upon a form submission, regardless of whether that form
submission succeeds?  Metric descriptions are frequently read by developers who
are only somewhat familiar with the instrumented feature, so it's very helpful
to be extremely clear and precise.

[vasilii, 2016/07/04 20:10:40]

Done.

[vasilii, 2016/07/04 20:10:41]

Done.

+  </description>
+</action>
+
 <action name="PasswordManager_Disabled">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>
@@ -12088,6 +12130,22 @@ should be able to be added at any place in this file.
   <description>Please enter the description of this user action.</description>
 </action>
 
+<action name="PasswordManager_OverridePassword">

[Ilya Sherman, 2016/07/01 17:59:54]

nit: Perhaps name this "LoggedInWithNewPassword"?  (Or something along those
lines, but shorter?  E.g. "Login" in place of "LoggedIn" would probably be
equally clear.)

[vasilii, 2016/07/04 20:10:41]

Done.

+  <owner>vasilii@chromium.org</owner>
+  <description>
+    User tries to log in with an existing (PSL or not) credential but different
+    password
+  </description>
+</action>
+
+<action name="PasswordManager_OverrideUsernameAndPassword">

[Ilya Sherman, 2016/07/01 17:59:54]

nit: Perhaps name this "LoggedInWithNewUsername" or "NewCredential"?  (I
personally prefer "username", since it clarifies what part of the credential is
being focused on.)

[vasilii, 2016/07/04 20:10:40]

Done.

+  <owner>vasilii@chromium.org</owner>
+  <description>
+    User tries to login with a completely new (possibly auto generated)

[Ilya Sherman, 2016/07/01 17:59:54]

nit: s/login/log in

[vasilii, 2016/07/04 20:10:40]

Done.

+    credential
+  </description>
+</action>
+
 <action name="PasswordManager_RemovePasswordException">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>
@@ -12098,6 +12156,16 @@ should be able to be added at any place in this file.
   <description>Please enter the description of this user action.</description>
 </action>
 
+<action name="PasswordManager_SubmitFailed">
+  <owner>vasilii@chromium.org</owner>
+  <description>Password form submission failed</description>

[Ilya Sherman, 2016/07/01 17:59:55]

This doesn't seem like a user action, per se.  What's the context for recording
this?

[vasilii, 2016/07/04 20:10:40]

It means that the login was unsuccessful from the Chrome point of view.

+</action>
+
+<action name="PasswordManager_SubmitPassed">
+  <owner>vasilii@chromium.org</owner>
+  <description>Password form submitted successfully</description>

[Ilya Sherman, 2016/07/01 17:59:55]

This doesn't seem like a user action, per se.  What's the context for recording
this?  If you're intending to use it as a proxy for a successful login, I
suspect it will be *very* far from accurate, as many websites will allow the
form submit to pass through, and then show a new page with an error message.

[vasilii, 2016/07/04 20:10:40]

It means that the password was probably correct.

+</action>
+
 <action name="PasswordManager_SyncCredentialShown">
   <owner>gcasto@chromium.org</owner>
   <owner>vabr@chromium.org</owner>