Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 211373004: Revert of Add PrivacyMode support to the QuicStreamFactory. (Closed)

Created:
6 years, 9 months ago by erikchen
Modified:
6 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Revert of Add PrivacyMode support to the QuicStreamFactory. (https://codereview.chromium.org/185773006/) Reason for revert: Reverted by request from kareng. It breaks the continuous official tests. ../../net/tools/quic/quic_client_bin.cc: In function ‘int main(int, char**)’: ../../net/tools/quic/quic_client_bin.cc:76:67: error: no matching function for call to ‘net::QuicSessionKey::QuicSessionKey(std::string&, int32&, bool&)’ ../../net/tools/quic/quic_client_bin.cc:76:67: note: candidates are: ../../net/quic/quic_session_key.h:23:3: note: net::QuicSessionKey::QuicSessionKey(const string&, uint16, bool, net::PrivacyMode) ../../net/quic/quic_session_key.h:23:3: note: candidate expects 4 arguments, 3 provided ../../net/quic/quic_session_key.h:20:3: note: net::QuicSessionKey::QuicSessionKey(const net::HostPortPair&, bool, net::PrivacyMode) ../../net/quic/quic_session_key.h:20:3: note: no known conversion for argument 1 from ‘std::string {aka std::basic_string<char>}’ to ‘const net::HostPortPair&’ ../../net/quic/quic_session_key.h:19:3: note: net::QuicSessionKey::QuicSessionKey() ../../net/quic/quic_session_key.h:19:3: note: candidate expects 0 arguments, 3 provided ../../net/quic/quic_session_key.h:17:26: note: net::QuicSessionKey::QuicSessionKey(const net::QuicSessionKey&) ../../net/quic/quic_session_key.h:17:26: note: candidate expects 1 argument, 3 provided Original issue's description: > Add PrivacyMode support to the QuicStreamFactory. > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259303 TBR=rtenneti@chromium.org,rch@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -203 lines) Patch
M net/http/disk_cache_based_quic_server_info_unittest.cc View 14 chunks +73 lines, -77 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config_test.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session_key.h View 3 chunks +2 lines, -11 lines 0 comments Download
M net/quic/quic_session_key.cc View 2 chunks +6 lines, -15 lines 0 comments Download
M net/quic/quic_session_key_test.cc View 1 chunk +2 lines, -14 lines 0 comments Download
M net/quic/quic_stream_factory.h View 4 chunks +3 lines, -4 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 11 chunks +16 lines, -17 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 38 chunks +8 lines, -39 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of Add PrivacyMode support to the QuicStreamFactory.
6 years, 9 months ago (2014-03-25 20:36:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/211373004/1
6 years, 9 months ago (2014-03-25 20:38:14 UTC) #2
commit-bot: I haz the power
Change committed as 259323
6 years, 9 months ago (2014-03-25 20:40:03 UTC) #3
ramant (doing other things)
6 years, 9 months ago (2014-03-25 20:45:49 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698