Speed up directory listing in pub.

sdk/lib/_internal/pub/test/io_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library io_test;
 
 import 'dart:async';
 import 'dart:io';
 
 import 'package:path/path.dart' as path;
 import 'package:unittest/unittest.dart';
 
 import '../lib/src/io.dart';
 import 'test_pub.dart';
 
 main() {
   initConfig();
 
   group('listDir', () {
-    test('lists a simple directory non-recursively', () {
-      expect(withTempDir((temp) {
-        writeTextFile(path.join(temp, 'file1.txt'), '');
-        writeTextFile(path.join(temp, 'file2.txt'), '');
-        createDir(path.join(temp, 'subdir'));
-        writeTextFile(path.join(temp, 'subdir', 'file3.txt'), '');
-
-        expect(listDir(temp), unorderedEquals([
-          path.join(temp, 'file1.txt'),
-          path.join(temp, 'file2.txt'),
-          path.join(temp, 'subdir')
-        ]));
-      }), completes);
-    });
-
-    test('lists a simple directory recursively', () {
-      expect(withTempDir((temp) {
-        writeTextFile(path.join(temp, 'file1.txt'), '');
-        writeTextFile(path.join(temp, 'file2.txt'), '');
-        createDir(path.join(temp, 'subdir'));
-        writeTextFile(path.join(temp, 'subdir', 'file3.txt'), '');
-
-        expect(listDir(temp, recursive: true), unorderedEquals([
-          path.join(temp, 'file1.txt'),
-          path.join(temp, 'file2.txt'),
-          path.join(temp, 'subdir'),
-          path.join(temp, 'subdir', 'file3.txt'),
-        ]));
-      }), completes);
-    });
-
     test('ignores hidden files by default', () {
       expect(withTempDir((temp) {
         writeTextFile(path.join(temp, 'file1.txt'), '');
         writeTextFile(path.join(temp, 'file2.txt'), '');
         writeTextFile(path.join(temp, '.file3.txt'), '');
         createDir(path.join(temp, '.subdir'));
         writeTextFile(path.join(temp, '.subdir', 'file3.txt'), '');
 
         expect(listDir(temp, recursive: true), unorderedEquals([
           path.join(temp, 'file1.txt'),
@@ skipping 13 matching lines @@
         expect(listDir(temp, recursive: true, includeHidden: true),
             unorderedEquals([
           path.join(temp, 'file1.txt'),
           path.join(temp, 'file2.txt'),
           path.join(temp, '.file3.txt'),
           path.join(temp, '.subdir'),
           path.join(temp, '.subdir', 'file3.txt')
         ]));
       }), completes);
     });
-
-    test('returns the unresolved paths for symlinks', () {
-      expect(withTempDir((temp) {
-        var dirToList = path.join(temp, 'dir-to-list');
-        createDir(path.join(temp, 'dir1'));
-        writeTextFile(path.join(temp, 'dir1', 'file1.txt'), '');
-        createDir(path.join(temp, 'dir2'));
-        writeTextFile(path.join(temp, 'dir2', 'file2.txt'), '');
-        createDir(dirToList);
-        createSymlink(
-            path.join(temp, 'dir1'),
-            path.join(dirToList, 'linked-dir1'));
-        createDir(path.join(dirToList, 'subdir'));
-        createSymlink(
-            path.join(temp, 'dir2'),
-            path.join(dirToList, 'subdir', 'linked-dir2'));
-
-        expect(listDir(dirToList, recursive: true), unorderedEquals([
-          path.join(dirToList, 'linked-dir1'),
-          path.join(dirToList, 'linked-dir1', 'file1.txt'),
-          path.join(dirToList, 'subdir'),
-          path.join(dirToList, 'subdir', 'linked-dir2'),
-          path.join(dirToList, 'subdir', 'linked-dir2', 'file2.txt'),
-        ]));
-      }), completes);
-    });
-
-    test('works with recursive symlinks', () {
-      expect(withTempDir((temp) {
-        writeTextFile(path.join(temp, 'file1.txt'), '');
-        createSymlink(temp, path.join(temp, 'linkdir'));
-
-        expect(listDir(temp, recursive: true), unorderedEquals([
-          path.join(temp, 'file1.txt'),
-          path.join(temp, 'linkdir')
-        ]));
-      }), completes);
-    });
-
-    test('treats a broken symlink as a file', () {
-      expect(withTempDir((temp) {
-        writeTextFile(path.join(temp, 'file1.txt'), '');
-        createDir(path.join(temp, 'dir'));
-        createSymlink(path.join(temp, 'dir'), path.join(temp, 'linkdir'));
-        deleteEntry(path.join(temp, 'dir'));
-
-        expect(listDir(temp, recursive: true), unorderedEquals([
-          path.join(temp, 'file1.txt'),
-          path.join(temp, 'linkdir')
-        ]));
-      }), completes);
-    });
   });
 
   group('canonicalize', () {
     test('resolves a non-link', () {
       expect(withCanonicalTempDir((temp) {
         var filePath = path.join(temp, 'file');
         writeTextFile(filePath, '');
         expect(canonicalize(filePath), equals(filePath));
       }), completes);
     });
@@ skipping 277 matching lines @@
           expect(predicate(symlink2Path), equals(forMultiLevelFileSymlink));
         }), completes);
       });
     }
   });
 }
 
 /// Like [withTempDir], but canonicalizes the path before passing it to [fn].
 Future withCanonicalTempDir(Future fn(String path)) =>
   withTempDir((temp) => fn(canonicalize(temp)));