Source/bindings/v8/WrapperTypeInfo.h - Issue 211373002: Oilpan: move DOMWindow object to the oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/WrapperTypeInfo.h

Issue 211373002: Oilpan: move DOMWindow object to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: setNativeInfoForInnerGlobalObject() -> setNativeInfoForHiddenWrapper() Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/WrapperTypeInfo.h

diff --git a/Source/bindings/v8/WrapperTypeInfo.h b/Source/bindings/v8/WrapperTypeInfo.h

index ca2a583fc5d2140dfa3c1a5b3b9538427f3d8809..dbba09e6f84bade0636bd933394f69f69045aed5 100644

--- a/Source/bindings/v8/WrapperTypeInfo.h

+++ b/Source/bindings/v8/WrapperTypeInfo.h

@@ -192,7 +192,8 @@ namespace WebCore {

#if ENABLE(OILPAN)

if (typeInfo->isGarbageCollected) {

const PersistentNode* handle = toPersistentHandle(wrapper);

- ASSERT(handle);

+ // This will be null iff a wrapper for a hidden wrapper object,

+ // see V8DOMWrapper::setNativeInfoForHiddenWrapper().

delete handle;

} else {

ASSERT(typeInfo->derefObjectFunction);

« no previous file with comments | « Source/bindings/v8/V8WindowShell.cpp ('k') | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »