Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: Source/bindings/v8/custom/V8WindowCustom.cpp

Issue 211373002: Oilpan: move DOMWindow object to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: setNativeInfoForInnerGlobalObject() -> setNativeInfoForHiddenWrapper() Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/WrapperTypeInfo.h ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 365 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullChe ck>, urlString, info[0]); 376 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullChe ck>, urlString, info[0]);
377 AtomicString frameName; 377 AtomicString frameName;
378 if (info[1]->IsUndefined() || info[1]->IsNull()) { 378 if (info[1]->IsUndefined() || info[1]->IsNull()) {
379 frameName = "_blank"; 379 frameName = "_blank";
380 } else { 380 } else {
381 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, frameNameResour ce, info[1]); 381 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, frameNameResour ce, info[1]);
382 frameName = frameNameResource; 382 frameName = frameNameResource;
383 } 383 }
384 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullChe ck>, windowFeaturesString, info[2]); 384 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullChe ck>, windowFeaturesString, info[2]);
385 385
386 RefPtr<DOMWindow> openedWindow = impl->open(urlString, frameName, windowFeat uresString, callingDOMWindow(info.GetIsolate()), enteredDOMWindow(info.GetIsolat e())); 386 RefPtrWillBeRawPtr<DOMWindow> openedWindow = impl->open(urlString, frameName , windowFeaturesString, callingDOMWindow(info.GetIsolate()), enteredDOMWindow(in fo.GetIsolate()));
387 if (!openedWindow) 387 if (!openedWindow)
388 return; 388 return;
389 389
390 v8SetReturnValueFast(info, openedWindow.release(), impl); 390 v8SetReturnValueFast(info, openedWindow.release(), impl);
391 } 391 }
392 392
393 void V8Window::namedPropertyGetterCustom(v8::Local<v8::String> name, const v8::P ropertyCallbackInfo<v8::Value>& info) 393 void V8Window::namedPropertyGetterCustom(v8::Local<v8::String> name, const v8::P ropertyCallbackInfo<v8::Value>& info)
394 { 394 {
395 395
396 DOMWindow* window = V8Window::toNative(info.Holder()); 396 DOMWindow* window = V8Window::toNative(info.Holder());
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 v8::Handle<v8::Context> context = toV8Context(isolate, frame, DOMWrapperWorl d::current(isolate)); 553 v8::Handle<v8::Context> context = toV8Context(isolate, frame, DOMWrapperWorl d::current(isolate));
554 if (context.IsEmpty()) 554 if (context.IsEmpty())
555 return v8Undefined(); 555 return v8Undefined();
556 556
557 v8::Handle<v8::Object> global = context->Global(); 557 v8::Handle<v8::Object> global = context->Global();
558 ASSERT(!global.IsEmpty()); 558 ASSERT(!global.IsEmpty());
559 return global; 559 return global;
560 } 560 }
561 561
562 } // namespace WebCore 562 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/WrapperTypeInfo.h ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698