Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: Source/bindings/v8/Dictionary.cpp

Issue 211373002: Oilpan: move DOMWindow object to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 return false; 313 return false;
314 314
315 V8TRYCATCH_RETURN(v8::Local<v8::Number>, v8Number, v8Value->ToNumber(), fals e); 315 V8TRYCATCH_RETURN(v8::Local<v8::Number>, v8Number, v8Value->ToNumber(), fals e);
316 if (v8Number.IsEmpty()) 316 if (v8Number.IsEmpty())
317 return false; 317 return false;
318 double d = v8Number->Value(); 318 double d = v8Number->Value();
319 doubleToInteger(d, value); 319 doubleToInteger(d, value);
320 return true; 320 return true;
321 } 321 }
322 322
323 bool Dictionary::get(const String& key, RefPtr<DOMWindow>& value) const 323 bool Dictionary::get(const String& key, RefPtrWillBeMember<DOMWindow>& value) co nst
324 { 324 {
325 v8::Local<v8::Value> v8Value; 325 v8::Local<v8::Value> v8Value;
326 if (!getKey(key, v8Value)) 326 if (!getKey(key, v8Value))
327 return false; 327 return false;
328 328
329 // We need to handle a DOMWindow specially, because a DOMWindow wrapper 329 // We need to handle a DOMWindow specially, because a DOMWindow wrapper
330 // exists on a prototype chain of v8Value. 330 // exists on a prototype chain of v8Value.
331 value = toDOMWindow(v8Value, m_isolate); 331 value = toDOMWindow(v8Value, m_isolate);
332 return true; 332 return true;
333 } 333 }
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
751 751
752 return *this; 752 return *this;
753 } 753 }
754 754
755 void Dictionary::ConversionContext::throwTypeError(const String& detail) 755 void Dictionary::ConversionContext::throwTypeError(const String& detail)
756 { 756 {
757 exceptionState().throwTypeError(detail); 757 exceptionState().throwTypeError(detail);
758 } 758 }
759 759
760 } // namespace WebCore 760 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698