Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2113673002: [stubs]: Convert FastNewContext stub to turbofan (Closed)

Created:
4 years, 5 months ago by danno
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs]: Convert FastNewContext stub to turbofan BUG=608675 Committed: https://crrev.com/8ab0e99eb84ee01af253b50f34cd8b2b0f785cae Cr-Commit-Position: refs/heads/master@{#37550}

Patch Set 1 #

Patch Set 2 : Fix builds #

Patch Set 3 : Rename based on feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -147 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/code-factory.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 2 3 chunks +8 lines, -11 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 chunks +52 lines, -3 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/interface-descriptors.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
danno
PTAL
4 years, 5 months ago (2016-07-06 08:37:58 UTC) #2
Benedikt Meurer
It'd be nice to apply the same cleanup that we used for FastNewClosureStub and compute ...
4 years, 5 months ago (2016-07-06 10:24:02 UTC) #3
danno
Totally agree on the cleanup, but I wanted to save that for a separate CL. ...
4 years, 5 months ago (2016-07-06 10:34:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113673002/40001
4 years, 5 months ago (2016-07-06 11:22:14 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-06 11:46:28 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 11:49:15 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8ab0e99eb84ee01af253b50f34cd8b2b0f785cae
Cr-Commit-Position: refs/heads/master@{#37550}

Powered by Google App Engine
This is Rietveld 408576698