[Refactring] Turn HTMLImport::m_sync from bool to an enum.

[Refactring] Turn HTMLImport::m_sync from bool to an enum.

This change introduces HTMLImport::SyncMode for readability.

TEST=none
BUG=356257
R=dominicc@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170067

[Hajime Morrita, 2014-03-25 22:56:25]

PTAL?

[dominicc (has gone to gerrit), 2014-03-26 01:04:27]

On 2014/03/25 22:56:25, morrita1 wrote:
> PTAL?

LGTM

You could also remove the default Sync parameter value, that's only used at
HTMLImportRoot, right?

Is it better if client->isSync() just return the SyncMode? That avoids the
ternary when you pass it through.

[Hajime Morrita, 2014-03-26 01:55:55]

Thanks for the review!

On 2014/03/26 01:04:27, dominicc wrote:
> On 2014/03/25 22:56:25, morrita1 wrote:
> > PTAL?
> 
> LGTM
> 
> You could also remove the default Sync parameter value, that's only used at
> HTMLImportRoot, right?
Right. Done.

> 
> Is it better if client->isSync() just return the SyncMode? That avoids the
> ternary when you pass it through.

Could be. For now I don't want to add another file that only contains this enum.
I'll do this when I add another enum.

[Hajime Morrita, 2014-03-26 01:56:12]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-03-26 01:57:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/211363004/60001

[commit-bot: I haz the power, 2014-03-26 02:03:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 02:03:38]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_compile_dbg

[Hajime Morrita, 2014-03-26 17:24:04]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-03-26 17:24:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/211363004/60001

[commit-bot: I haz the power, 2014-03-26 17:45:49]

Change committed as 170067