Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2113623002: Revert of [compiler] Load elimination now traverses CheckTaggedPointer. (Closed)

Created:
4 years, 5 months ago by Jarin
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, bgeron
CC:
v8-reviews_googlegroups.com, Jarin
Base URL:
https://chromium.googlesource.com/v8/v8.git@p7-base
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [compiler] Load elimination now traverses CheckTaggedPointer. (patchset #1 id:1 of https://codereview.chromium.org/2104893002/ ) Reason for revert: Clusterfuzz breakage (https://bugs.chromium.org/p/chromium/issues/detail?id=624756) Original issue's description: > [compiler] Load elimination now traverses CheckTaggedPointer. > > It also dereferences the inputs of StoreField, if those were > CheckTaggedPointers. Tested manually. > > BUG= > > Committed: https://crrev.com/f416886358c0aeaa5b4d1e83d9c7d6bb8b0e7f2f > Cr-Commit-Position: refs/heads/master@{#37330} TBR=bmeurer@chromium.org,bgeron@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/f496f80fa813b368348f0ca4d180a39839eb97f6 Cr-Commit-Position: refs/heads/master@{#37438}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M src/compiler/load-elimination.cc View 3 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Created Revert of [compiler] Load elimination now traverses CheckTaggedPointer.
4 years, 5 months ago (2016-06-30 11:46:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113623002/1
4 years, 5 months ago (2016-06-30 11:46:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 12:12:03 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 12:12:06 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 12:14:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f496f80fa813b368348f0ca4d180a39839eb97f6
Cr-Commit-Position: refs/heads/master@{#37438}

Powered by Google App Engine
This is Rietveld 408576698