Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: src/interpreter/bytecode-array-builder.cc

Issue 2113613002: [Interpereter] Inline FastNewClosure into CreateClosure bytecode handler (Closed) Base URL: ssh://rmcilroy.lon.corp.google.com///usr/local/google/code/v8_full/v8@int_context
Patch Set: Rebaseline bytecode expectations Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/bytecode-array-builder.h ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/interpreter/bytecode-array-builder.h" 5 #include "src/interpreter/bytecode-array-builder.h"
6 6
7 #include "src/compiler.h" 7 #include "src/compiler.h"
8 #include "src/globals.h" 8 #include "src/globals.h"
9 #include "src/interpreter/bytecode-array-writer.h" 9 #include "src/interpreter/bytecode-array-writer.h"
10 #include "src/interpreter/bytecode-dead-code-optimizer.h" 10 #include "src/interpreter/bytecode-dead-code-optimizer.h"
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 BytecodeArrayBuilder& BytecodeArrayBuilder::StoreKeyedProperty( 316 BytecodeArrayBuilder& BytecodeArrayBuilder::StoreKeyedProperty(
317 Register object, Register key, int feedback_slot, 317 Register object, Register key, int feedback_slot,
318 LanguageMode language_mode) { 318 LanguageMode language_mode) {
319 Bytecode bytecode = BytecodeForStoreKeyedProperty(language_mode); 319 Bytecode bytecode = BytecodeForStoreKeyedProperty(language_mode);
320 Output(bytecode, RegisterOperand(object), RegisterOperand(key), 320 Output(bytecode, RegisterOperand(object), RegisterOperand(key),
321 UnsignedOperand(feedback_slot)); 321 UnsignedOperand(feedback_slot));
322 return *this; 322 return *this;
323 } 323 }
324 324
325 BytecodeArrayBuilder& BytecodeArrayBuilder::CreateClosure( 325 BytecodeArrayBuilder& BytecodeArrayBuilder::CreateClosure(
326 Handle<SharedFunctionInfo> shared_info, PretenureFlag tenured) { 326 Handle<SharedFunctionInfo> shared_info, int flags) {
327 size_t entry = GetConstantPoolEntry(shared_info); 327 size_t entry = GetConstantPoolEntry(shared_info);
328 Output(Bytecode::kCreateClosure, UnsignedOperand(entry), 328 Output(Bytecode::kCreateClosure, UnsignedOperand(entry),
329 UnsignedOperand(static_cast<size_t>(tenured))); 329 UnsignedOperand(flags));
330 return *this; 330 return *this;
331 } 331 }
332 332
333 BytecodeArrayBuilder& BytecodeArrayBuilder::CreateArguments( 333 BytecodeArrayBuilder& BytecodeArrayBuilder::CreateArguments(
334 CreateArgumentsType type) { 334 CreateArgumentsType type) {
335 // TODO(rmcilroy): Consider passing the type as a bytecode operand rather 335 // TODO(rmcilroy): Consider passing the type as a bytecode operand rather
336 // than having two different bytecodes once we have better support for 336 // than having two different bytecodes once we have better support for
337 // branches in the InterpreterAssembler. 337 // branches in the InterpreterAssembler.
338 Bytecode bytecode = BytecodeForCreateArguments(type); 338 Bytecode bytecode = BytecodeForCreateArguments(type);
339 Output(bytecode); 339 Output(bytecode);
(...skipping 591 matching lines...) Expand 10 before | Expand all | Expand 10 after
931 return Bytecode::kTailCall; 931 return Bytecode::kTailCall;
932 default: 932 default:
933 UNREACHABLE(); 933 UNREACHABLE();
934 } 934 }
935 return Bytecode::kIllegal; 935 return Bytecode::kIllegal;
936 } 936 }
937 937
938 } // namespace interpreter 938 } // namespace interpreter
939 } // namespace internal 939 } // namespace internal
940 } // namespace v8 940 } // namespace v8
OLDNEW
« no previous file with comments | « src/interpreter/bytecode-array-builder.h ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698