Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Issue 2113613002: [Interpereter] Inline FastNewClosure into CreateClosure bytecode handler (Closed)

Created:
4 years, 5 months ago by rmcilroy
Modified:
4 years, 5 months ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
ssh://rmcilroy.lon.corp.google.com///usr/local/google/code/v8_full/v8@int_context
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpereter] Inline FastNewClosure into CreateClosure bytecode handler BUG=v8:4280 Committed: https://crrev.com/02c3414d6283a5c98f0ba0bec484b216ee2a0c8f Cr-Commit-Position: refs/heads/master@{#37453}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebaseline bytecode expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -69 lines) Patch
M src/interpreter/bytecode-array-builder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 chunks +7 lines, -14 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 1 chunk +17 lines, -1 line 0 comments Download
M src/interpreter/bytecodes.cc View 1 2 chunks +28 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 1 chunk +19 lines, -7 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BasicLoops.golden View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CompoundExpressions.golden View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ContextParameters.golden View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ContextVariables.golden View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CountOperators.golden View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Delete.golden View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/FunctionLiterals.golden View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LetVariableContextSlot.golden View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden View 1 2 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113613002/20001
4 years, 5 months ago (2016-06-30 11:37:46 UTC) #3
commit-bot: I haz the power
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in ...
4 years, 5 months ago (2016-06-30 11:37:48 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113613002/30001
4 years, 5 months ago (2016-06-30 11:49:16 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113613002/50001
4 years, 5 months ago (2016-06-30 12:07:33 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/builds/4271) v8_linux_nodcheck_rel_ng_triggered on ...
4 years, 5 months ago (2016-06-30 12:24:03 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113613002/70001
4 years, 5 months ago (2016-06-30 12:46:03 UTC) #14
rmcilroy
Mythri, PTAL thanks.
4 years, 5 months ago (2016-06-30 12:46:20 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 13:07:24 UTC) #18
mythria
lgtm
4 years, 5 months ago (2016-06-30 13:31:11 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113613002/70001
4 years, 5 months ago (2016-06-30 15:30:31 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:70001)
4 years, 5 months ago (2016-06-30 15:32:41 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 15:33:08 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/02c3414d6283a5c98f0ba0bec484b216ee2a0c8f
Cr-Commit-Position: refs/heads/master@{#37453}

Powered by Google App Engine
This is Rietveld 408576698