DBC: Various instructions.

runtime/vm/simulator_dbc.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <setjmp.h>  // NOLINT
 #include <stdlib.h>
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_DBC)
 
@@ skipping 2176 matching lines @@
     BYTECODE(IfNeStrict, A_D);
     RawObject* lhs = FP[rA];
     RawObject* rhs = FP[rD];
     if (lhs == rhs) {
       pc++;
     }
     DISPATCH();
   }
 
   {
+    BYTECODE(IfLe, A_D);
+    const intptr_t lhs = reinterpret_cast<intptr_t>(FP[rA]);
+    const intptr_t rhs = reinterpret_cast<intptr_t>(FP[rD]);
+    if (lhs > rhs) {
+      pc++;
+    }
+    DISPATCH();
+  }
+
+  {
+    BYTECODE(IfLt, A_D);
+    const intptr_t lhs = reinterpret_cast<intptr_t>(FP[rA]);
+    const intptr_t rhs = reinterpret_cast<intptr_t>(FP[rD]);
+    if (lhs >= rhs) {
+      pc++;
+    }
+    DISPATCH();
+  }
+
+  {
+    BYTECODE(IfGe, A_D);
+    const intptr_t lhs = reinterpret_cast<intptr_t>(FP[rA]);
+    const intptr_t rhs = reinterpret_cast<intptr_t>(FP[rD]);
+    if (lhs < rhs) {
+      pc++;
+    }
+    DISPATCH();
+  }
+
+  {
+    BYTECODE(IfGt, A_D);
+    const intptr_t lhs = reinterpret_cast<intptr_t>(FP[rA]);
+    const intptr_t rhs = reinterpret_cast<intptr_t>(FP[rD]);
+    if (lhs <= rhs) {
+      pc++;
+    }
+    DISPATCH();
+  }
+
+  {
     BYTECODE(IfEqStrictNum, A_D);
     RawObject* lhs = FP[rA];
     RawObject* rhs = FP[rD];
     if (!SimulatorHelpers::IsStrictEqualWithNumberCheck(lhs, rhs)) {
       pc++;
     }
     DISPATCH();
   }
 
   {
@@ skipping 63 matching lines @@
     RawSmi* index = static_cast<RawSmi*>(FP[rB]);
     RawObject* value = FP[rC];
     ASSERT(array->GetClassId() == kArrayCid);
     ASSERT(!index->IsHeapObject());
     ASSERT(SimulatorHelpers::CheckIndex(index, array->ptr()->length_));
     array->StorePointer(array->ptr()->data() + Smi::Value(index), value);
     DISPATCH();
   }
 
   {
+    BYTECODE(LoadIndexed, A_B_C);
+    RawArray* array = static_cast<RawArray*>(FP[rB]);

[Vyacheslav Egorov (Google), 2016/06/30 15:55:26]

Consider using RAW_CAST instead of assertions below.

(static_cast + assertions was an outdated way to write this code introduced
before RAW_CAST was introduced)

[zra, 2016/06/30 17:32:31]

Done here, and some others that I saw.

+    RawSmi* index = static_cast<RawSmi*>(FP[rC]);
+    ASSERT(array->GetClassId() == kArrayCid);
+    ASSERT(!index->IsHeapObject());
+    ASSERT(SimulatorHelpers::CheckIndex(index, array->ptr()->length_));
+    FP[rA] = *(array->ptr()->data() + Smi::Value(index));

[Vyacheslav Egorov (Google), 2016/06/30 15:55:26]

I suggest array->ptr()->data[Smi::Value(index)] here.

[zra, 2016/06/30 17:32:31]

Done.

+    DISPATCH();
+  }
+
+  {
     BYTECODE(Deopt, A_D);
     const bool is_lazy = rD == 0;
 
     // Preserve result of the previous call.
     // TODO(vegorov) we could have actually included result into the
     // deoptimization environment because it is passed through the stack.
     // If we do then we could remove special result handling from this code.
     RawObject* result = SP[0];
 
     // When not preserving the result, we still need to preserve SP[0] as it
@@ skipping 164 matching lines @@
   special_[kExceptionSpecialIndex] = raw_exception;
   special_[kStacktraceSpecialIndex] = raw_stacktrace;
   buf->Longjmp();
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 
 #endif  // defined TARGET_ARCH_DBC