Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2113533002: Makes BitmapUploader handle null GLES2Context (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
Reviewers:
Peng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes BitmapUploader handle null GLES2Context Tests can hit this if mus is shutting down. Makes code early out, assuming mus is in the process of shutting down. BUG=594600 TEST=none R=penghuang@chromium.org Committed: https://crrev.com/8de9670ba51e7495887e666bfefa3728c1a37933 Cr-Commit-Position: refs/heads/master@{#403007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M components/bitmap_uploader/bitmap_uploader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 5 months ago (2016-06-29 23:08:56 UTC) #1
Peng
On 2016/06/29 23:08:56, sky wrote: lgtm
4 years, 5 months ago (2016-06-29 23:15:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113533002/1
4 years, 5 months ago (2016-06-29 23:22:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 00:11:23 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 00:14:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8de9670ba51e7495887e666bfefa3728c1a37933
Cr-Commit-Position: refs/heads/master@{#403007}

Powered by Google App Engine
This is Rietveld 408576698