Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: remoting/protocol/video_renderer.h

Issue 2113523007: More cleanups in FrameStats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix android Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/performance_tracker.cc ('k') | remoting/protocol/webrtc_connection_to_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/video_renderer.h
diff --git a/remoting/protocol/video_renderer.h b/remoting/protocol/video_renderer.h
index d66a046ca5b03caff22e64e2bd36d051b22d332f..9b3ab1b64f99438fbba2f548868d0d21cff47385 100644
--- a/remoting/protocol/video_renderer.h
+++ b/remoting/protocol/video_renderer.h
@@ -12,14 +12,16 @@ class ClientContext;
namespace protocol {
class FrameConsumer;
-class PerformanceTracker;
+class FrameStatsConsumer;
class SessionConfig;
class VideoStub;
// VideoRenderer is responsible for decoding and displaying incoming video
// stream. This interface is used by ConnectionToHost implementations to
// render received video frames. ConnectionToHost may feed encoded frames to the
-// VideoStub or decode them and pass decoded frames to the FrameConsumer.
+// VideoStub or decode them and pass decoded frames to the FrameConsumer. If the
+// implementation uses FrameConsumer directly then it must also call
+// FrameStatsConsumer with FrameStats for each frame.
//
// TODO(sergeyu): Reconsider this design.
class VideoRenderer {
@@ -32,7 +34,7 @@ class VideoRenderer {
// should always return true.
// |perf_tracker| must outlive the renderer.
virtual bool Initialize(const ClientContext& client_context,
- protocol::PerformanceTracker* perf_tracker) = 0;
+ protocol::FrameStatsConsumer* stats_consumer) = 0;
// Configures the renderer with the supplied |config|. This must be called
// exactly once before video data is supplied to the renderer.
@@ -43,6 +45,9 @@ class VideoRenderer {
// Returns the FrameConsumer interface for this renderer.
virtual FrameConsumer* GetFrameConsumer() = 0;
+
+ // Returns the FrameStatsConsumer interface for this renderer.
+ virtual FrameStatsConsumer* GetFrameStatsConsumer() = 0;
};
} // namespace protocol
« no previous file with comments | « remoting/protocol/performance_tracker.cc ('k') | remoting/protocol/webrtc_connection_to_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698