Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2113523007: More cleanups in FrameStats (Closed)

Created:
3 years, 2 months ago by Sergey Ulanov
Modified:
3 years, 2 months ago
Reviewers:
Jamie, kelvinp
CC:
chromium-reviews, posciak+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More cleanups in FrameStats 1. Separated HostFrameStats and ClientFrameStats. This will allow to track host and client stats separately. 2. Added FrameStatsConsumer interface to allow verify that FrameStats are generated correctly. 3. Added VideoRenderer::GetFrameStatsConsumer() and changed WebrtcVideoRendererAdapter to get VideoRenderer instead of FrameConsumer, so now the adapter can report FrameStats. BUG=621691 Committed: https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1 Cr-Commit-Position: refs/heads/master@{#403953}

Patch Set 1 : . #

Patch Set 2 : fix compile issues #

Patch Set 3 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -149 lines) Patch
M remoting/client/chromoting_client.h View 2 chunks +1 line, -4 lines 0 comments Download
M remoting/client/jni/jni_video_renderer.h View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M remoting/client/jni/jni_video_renderer.cc View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M remoting/client/plugin/pepper_video_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_video_renderer_2d.h View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/client/plugin/pepper_video_renderer_2d.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_video_renderer_3d.h View 3 chunks +7 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_video_renderer_3d.cc View 3 chunks +22 lines, -11 lines 0 comments Download
M remoting/client/software_video_renderer.h View 3 chunks +10 lines, -9 lines 0 comments Download
M remoting/client/software_video_renderer.cc View 6 chunks +19 lines, -15 lines 0 comments Download
M remoting/protocol/fake_video_renderer.h View 3 chunks +23 lines, -1 line 0 comments Download
M remoting/protocol/fake_video_renderer.cc View 2 chunks +23 lines, -2 lines 0 comments Download
M remoting/protocol/frame_stats.h View 2 chunks +32 lines, -9 lines 0 comments Download
M remoting/protocol/frame_stats.cc View 2 chunks +15 lines, -6 lines 0 comments Download
M remoting/protocol/performance_tracker.h View 3 chunks +5 lines, -6 lines 0 comments Download
M remoting/protocol/performance_tracker.cc View 3 chunks +57 lines, -48 lines 0 comments Download
M remoting/protocol/video_renderer.h View 3 chunks +8 lines, -3 lines 0 comments Download
M remoting/protocol/webrtc_connection_to_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/webrtc_video_renderer_adapter.h View 2 chunks +7 lines, -7 lines 0 comments Download
M remoting/protocol/webrtc_video_renderer_adapter.cc View 4 chunks +11 lines, -9 lines 0 comments Download
M remoting/test/protocol_perftest.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M remoting/test/test_chromoting_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/test/test_video_renderer.h View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/test/test_video_renderer.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Sergey Ulanov
3 years, 2 months ago (2016-07-02 00:23:35 UTC) #5
kelvinp
lgtm
3 years, 2 months ago (2016-07-06 18:00:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113523007/40001
3 years, 2 months ago (2016-07-06 18:42:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/91980)
3 years, 2 months ago (2016-07-06 19:22:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113523007/40001
3 years, 2 months ago (2016-07-06 19:24:37 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/92284)
3 years, 2 months ago (2016-07-06 19:56:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113523007/60001
3 years, 2 months ago (2016-07-06 20:16:46 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:60001)
3 years, 2 months ago (2016-07-06 21:07:39 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
3 years, 2 months ago (2016-07-06 21:08:07 UTC) #20
commit-bot: I haz the power
3 years, 2 months ago (2016-07-06 21:10:30 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1
Cr-Commit-Position: refs/heads/master@{#403953}

Powered by Google App Engine
This is Rietveld 408576698