Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2113523002: DBC: Implement TestSmi instruction. (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DBC: Implement TestSmi instruction. Somewhat simplify branch generation. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/17e0b56025bdc6e03e56dabd4f0efd1b37cc279b

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -28 lines) Patch
M runtime/vm/assembler_dbc_test.cc View 1 1 chunk +44 lines, -0 lines 0 comments Download
M runtime/vm/constants_dbc.h View 1 3 chunks +11 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 1 7 chunks +53 lines, -27 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 5 months ago (2016-06-29 22:48:11 UTC) #2
zra
lgtm https://codereview.chromium.org/2113523002/diff/1/runtime/vm/assembler_dbc_test.cc File runtime/vm/assembler_dbc_test.cc (right): https://codereview.chromium.org/2113523002/diff/1/runtime/vm/assembler_dbc_test.cc#newcode1653 runtime/vm/assembler_dbc_test.cc:1653: Extra newline https://codereview.chromium.org/2113523002/diff/1/runtime/vm/constants_dbc.h File runtime/vm/constants_dbc.h (right): https://codereview.chromium.org/2113523002/diff/1/runtime/vm/constants_dbc.h#newcode648 runtime/vm/constants_dbc.h:648: ...
4 years, 5 months ago (2016-06-29 22:57:01 UTC) #3
rmacnak
https://codereview.chromium.org/2113523002/diff/1/runtime/vm/assembler_dbc_test.cc File runtime/vm/assembler_dbc_test.cc (right): https://codereview.chromium.org/2113523002/diff/1/runtime/vm/assembler_dbc_test.cc#newcode1653 runtime/vm/assembler_dbc_test.cc:1653: On 2016/06/29 22:57:01, zra wrote: > Extra newline Done. ...
4 years, 5 months ago (2016-06-29 23:53:51 UTC) #4
rmacnak
4 years, 5 months ago (2016-06-29 23:54:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
17e0b56025bdc6e03e56dabd4f0efd1b37cc279b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698