Make RootScroller set the outer viewport scroll layer in the compositor

third_party/WebKit/Source/web/tests/RootScrollerTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/TopControls.h"
 #include "core/html/HTMLFrameOwnerElement.h"
 #include "core/page/Page.h"
+#include "core/page/scrolling/RootScrollerController.h"
 #include "platform/testing/URLTestHelpers.h"
 #include "platform/testing/UnitTestHelpers.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebURLLoaderMockFactory.h"
 #include "public/web/WebCache.h"
 #include "public/web/WebConsoleMessage.h"
 #include "public/web/WebScriptSource.h"
 #include "public/web/WebSettings.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "web/WebLocalFrameImpl.h"
@@ skipping 128 matching lines @@
     VisualViewport& visualViewport() const
     {
         return frameHost().visualViewport();
     }
 
     TopControls& topControls() const
     {
         return frameHost().topControls();
     }
 
+    Element* effectiveRootScroller(Document* doc) const
+    {
+        return doc->rootScrollerController()->effectiveRootScroller();
+    }
+
 protected:
     std::string m_baseURL;
     RootScrollerTestWebViewClient m_client;
     FrameTestHelpers::WebViewHelper m_helper;
     RuntimeEnabledFeatures::Backup m_featuresBackup;
 };
 
 // Test that no root scroller element is set if setRootScroller isn't called on
 // any elements. The document element should be the default effective root
 // scroller.
 TEST_F(RootScrollerTest, TestDefaultRootScroller)
 {
     initialize("overflow-scrolling.html");
 
     ASSERT_EQ(nullptr, mainFrame()->document()->rootScroller());
 
     Element* htmlElement = mainFrame()->document()->documentElement();
-    EXPECT_EQ(htmlElement, mainFrame()->document()->effectiveRootScroller());
+    EXPECT_EQ(htmlElement, effectiveRootScroller(mainFrame()->document()));
 }
 
 // Tests that setting an element as the root scroller causes it to control url
 // bar hiding and overscroll.
 TEST_F(RootScrollerTest, TestSetRootScroller)
 {
     initialize("root-scroller.html");
 
     Element* container = mainFrame()->document()->getElementById("container");
     TrackExceptionState exceptionState;
@@ skipping 101 matching lines @@
 {
     initialize("root-scroller.html");
 
     ASSERT_EQ(nullptr, mainFrame()->document()->rootScroller());
 
     Element* container = mainFrame()->document()->getElementById("container");
     TrackExceptionState exceptionState;
     mainFrame()->document()->setRootScroller(container, exceptionState);
 
     ASSERT_EQ(container, mainFrame()->document()->rootScroller());
-    ASSERT_EQ(container, mainFrame()->document()->effectiveRootScroller());
+    ASSERT_EQ(container, effectiveRootScroller(mainFrame()->document()));
 
     mainFrame()->document()->body()->removeChild(container);
     mainFrameView()->updateAllLifecyclePhases();
 
     ASSERT_EQ(container, mainFrame()->document()->rootScroller());
-    ASSERT_NE(container, mainFrame()->document()->effectiveRootScroller());
+    ASSERT_NE(container, effectiveRootScroller(mainFrame()->document()));
 }
 
 // Tests that setting an element that isn't a valid scroller as the root
 // scroller doesn't change the effective root scroller.
 TEST_F(RootScrollerTest, TestSetRootScrollerOnInvalidElement)
 {
     initialize("root-scroller.html");
 
     {
         // Set to a non-block element. Should be rejected and a console message
         // logged.
         Element* element = mainFrame()->document()->getElementById("nonBlock");
         TrackExceptionState exceptionState;
         mainFrame()->document()->setRootScroller(element, exceptionState);
         mainFrameView()->updateAllLifecyclePhases();
         ASSERT_EQ(element, mainFrame()->document()->rootScroller());
-        ASSERT_NE(element, mainFrame()->document()->effectiveRootScroller());
+        ASSERT_NE(element, effectiveRootScroller(mainFrame()->document()));
     }
 
     {
         // Set to an element with no size.
         Element* element = mainFrame()->document()->getElementById("empty");
         TrackExceptionState exceptionState;
         mainFrame()->document()->setRootScroller(element, exceptionState);
         mainFrameView()->updateAllLifecyclePhases();
         ASSERT_EQ(element, mainFrame()->document()->rootScroller());
-        ASSERT_NE(element, mainFrame()->document()->effectiveRootScroller());
+        ASSERT_NE(element, effectiveRootScroller(mainFrame()->document()));
     }
 }
 
 // Test that the effective root scroller resets to the default element when the
 // current root scroller element becomes invalid as a scroller.
 TEST_F(RootScrollerTest, TestRootScrollerBecomesInvalid)
 {
     initialize("root-scroller.html");
 
     Element* htmlElement = mainFrame()->document()->documentElement();
     Element* container = mainFrame()->document()->getElementById("container");
     TrackExceptionState exceptionState;
 
     ASSERT_EQ(nullptr, mainFrame()->document()->rootScroller());
-    ASSERT_EQ(htmlElement, mainFrame()->document()->effectiveRootScroller());
+    ASSERT_EQ(htmlElement, effectiveRootScroller(mainFrame()->document()));
 
     {
         mainFrame()->document()->setRootScroller(container, exceptionState);
         mainFrameView()->updateAllLifecyclePhases();
 
         ASSERT_EQ(container, mainFrame()->document()->rootScroller());
-        ASSERT_EQ(container, mainFrame()->document()->effectiveRootScroller());
+        ASSERT_EQ(container, effectiveRootScroller(mainFrame()->document()));
 
         executeScript(
             "document.querySelector('#container').style.display = 'inline'");
         mainFrameView()->updateAllLifecyclePhases();
 
         ASSERT_EQ(container, mainFrame()->document()->rootScroller());
         ASSERT_EQ(htmlElement,
-            mainFrame()->document()->effectiveRootScroller());
+            effectiveRootScroller(mainFrame()->document()));
     }
 
     executeScript(
         "document.querySelector('#container').style.display = 'block'");
     mainFrame()->document()->setRootScroller(nullptr, exceptionState);
     mainFrameView()->updateAllLifecyclePhases();
     ASSERT_EQ(nullptr, mainFrame()->document()->rootScroller());
-    ASSERT_EQ(htmlElement, mainFrame()->document()->effectiveRootScroller());
+    ASSERT_EQ(htmlElement, effectiveRootScroller(mainFrame()->document()));
 
     {
         mainFrame()->document()->setRootScroller(container, exceptionState);
         mainFrameView()->updateAllLifecyclePhases();
 
         ASSERT_EQ(container, mainFrame()->document()->rootScroller());
-        ASSERT_EQ(container, mainFrame()->document()->effectiveRootScroller());
+        ASSERT_EQ(container, effectiveRootScroller(mainFrame()->document()));
 
         executeScript(
             "document.querySelector('#container').style.width = '98%'");
         mainFrameView()->updateAllLifecyclePhases();
 
         ASSERT_EQ(container, mainFrame()->document()->rootScroller());
         ASSERT_EQ(htmlElement,
-            mainFrame()->document()->effectiveRootScroller());
+            effectiveRootScroller(mainFrame()->document()));
     }
 }
 
 // Tests that setting the root scroller of the top document to an element that
 // belongs to a nested document works.
 TEST_F(RootScrollerTest, TestSetRootScrollerOnElementInIframe)
 {
     initialize("root-scroller-iframe.html");
 
     ASSERT_EQ(nullptr, mainFrame()->document()->rootScroller());
 
     {
         // Trying to set an element from a nested document should fail.
         HTMLFrameOwnerElement* iframe = toHTMLFrameOwnerElement(
             mainFrame()->document()->getElementById("iframe"));
         Element* innerContainer =
             iframe->contentDocument()->getElementById("container");
 
         TrackExceptionState exceptionState;
         mainFrame()->document()->setRootScroller(
             innerContainer,
             exceptionState);
         mainFrameView()->updateAllLifecyclePhases();
 
         ASSERT_EQ(innerContainer, mainFrame()->document()->rootScroller());
         ASSERT_EQ(innerContainer,
-            mainFrame()->document()->effectiveRootScroller());
+            effectiveRootScroller(mainFrame()->document()));
     }
 
     {
         // Setting the iframe itself should also work.
         HTMLFrameOwnerElement* iframe = toHTMLFrameOwnerElement(
             mainFrame()->document()->getElementById("iframe"));
 
         TrackExceptionState exceptionState;
         mainFrame()->document()->setRootScroller(iframe, exceptionState);
         mainFrameView()->updateAllLifecyclePhases();
 
         ASSERT_EQ(iframe, mainFrame()->document()->rootScroller());
-        ASSERT_EQ(iframe, mainFrame()->document()->effectiveRootScroller());
+        ASSERT_EQ(iframe, effectiveRootScroller(mainFrame()->document()));
     }
 }
 
 // Tests that setting a valid element as the root scroller on a document within
 // an iframe works as expected.
 TEST_F(RootScrollerTest, TestRootScrollerWithinIframe)
 {
     initialize("root-scroller-iframe.html");
 
     ASSERT_EQ(nullptr, mainFrame()->document()->rootScroller());
 
     {
         HTMLFrameOwnerElement* iframe = toHTMLFrameOwnerElement(
             mainFrame()->document()->getElementById("iframe"));
 
         ASSERT_EQ(iframe->contentDocument()->documentElement(),
-            iframe->contentDocument()->effectiveRootScroller());
+            effectiveRootScroller(iframe->contentDocument()));
 
         Element* innerContainer =
             iframe->contentDocument()->getElementById("container");
         TrackExceptionState exceptionState;
         iframe->contentDocument()->setRootScroller(
             innerContainer,
             exceptionState);
         mainFrameView()->updateAllLifecyclePhases();
 
         ASSERT_EQ(innerContainer, iframe->contentDocument()->rootScroller());
         ASSERT_EQ(innerContainer,
-            iframe->contentDocument()->effectiveRootScroller());
+            effectiveRootScroller(iframe->contentDocument()));
     }
 }
 
 // Tests that trying to set an element as the root scroller of a document inside
 // an iframe fails when that element belongs to the parent document.
 // TODO(bokan): Recent changes mean this is now possible but should be fixed.
 TEST_F(RootScrollerTest, DISABLED_TestSetRootScrollerOnElementFromOutsideIframe)
 {
     initialize("root-scroller-iframe.html");
 
@@ skipping 22 matching lines @@
             body,
             exceptionState);
 
         ASSERT_EQ(body, iframe->contentDocument()->rootScroller());
     }
 }
 
 } // namespace
 
 } // namespace blink