Add a Physical Web data source

ios/chrome/common/physical_web/physical_web_scanner.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/common/physical_web/physical_web_scanner.h"
 
+#import <CoreBluetooth/CoreBluetooth.h>
+
 #include <string>
 #include <vector>
 
-#import <CoreBluetooth/CoreBluetooth.h>
-
-#include "base/ios/weak_nsobject.h"
+#import "base/ios/weak_nsobject.h"
 #include "base/logging.h"
-#include "base/mac/scoped_nsobject.h"
-#include "base/macros.h"
+#import "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
 #include "device/bluetooth/uribeacon/uri_encoder.h"
-#include "ios/chrome/common/physical_web/physical_web_device.h"
+#import "ios/chrome/common/physical_web/physical_web_device.h"
 #import "ios/chrome/common/physical_web/physical_web_request.h"
-#include "ios/chrome/common/physical_web/physical_web_types.h"
+#import "ios/chrome/common/physical_web/physical_web_types.h"
 
 namespace {
 
 NSString* const kUriBeaconServiceUUID = @"FED8";
 NSString* const kEddystoneBeaconServiceUUID = @"FEAA";
 
 enum BeaconType {
   BEACON_TYPE_NONE,
   BEACON_TYPE_URIBEACON,
   BEACON_TYPE_EDDYSTONE,
@@ skipping 111 matching lines @@
     if ([device1 rank] > [device2 rank]) {
       return NSOrderedDescending;
     }
     if ([device1 rank] < [device2 rank]) {
       return NSOrderedAscending;
     }
     return NSOrderedSame;
   }];
 }
 
+- (std::unique_ptr<base::ListValue>)metadata {
+  std::unique_ptr<base::ListValue> metadataList(new base::ListValue());
+
+  NSInteger deviceCount = [[self devices] count];
+  for (int i = 0; i < deviceCount; ++i) {
+    PhysicalWebDevice* device = [[self devices] objectAtIndex:i];
+    const char* scannedUrl = [[[device requestURL] absoluteString] UTF8String];

[sdefresne, 2016/08/02 22:23:36]

Use base::SysNSStringToUTF8 (it returns std::string, but since
base::DictionaryValue::SetString takes its second parameter as a std::string,
there is no point avoiding the std::string here). It deal correctly with nil or
empty NSString.

Here and for the other values too.

[mattreynolds, 2016/08/04 00:56:13]

Done.

+    const char* resolvedUrl = [[[device url] absoluteString] UTF8String];
+    const char* icon = [[[device icon] absoluteString] UTF8String];
+    const char* title = [[device title] UTF8String];
+    const char* description = [[device description] UTF8String];
+
+    // Provide defaults for optional fields.

[sdefresne, 2016/08/02 22:23:36]

You can remove this if using base::SysNSStringToUTF8.

[mattreynolds, 2016/08/04 00:56:12]

Done.

+    if (!icon) {
+      icon = "";
+    }
+    if (!title) {
+      title = "";
+    }
+    if (!description) {
+      description = "";
+    }
+
+    base::DictionaryValue* metadataItem = new base::DictionaryValue();
+    metadataItem->SetString("scannedUrl", scannedUrl);
+    metadataItem->SetString("resolvedUrl", resolvedUrl);
+    metadataItem->SetString("icon", icon);
+    metadataItem->SetString("title", title);
+    metadataItem->SetString("description", description);
+    metadataList->Append(metadataItem);
+  }
+
+  return metadataList;
+}
+
 - (void)setNetworkRequestEnabled:(BOOL)enabled {
   if (networkRequestEnabled_ == enabled) {
     return;
   }
   networkRequestEnabled_ = enabled;
   if (!networkRequestEnabled_)
     return;
 
   // Sends the pending requests.
   for (PhysicalWebDevice* device in unresolvedDevices_.get()) {
@@ skipping 159 matching lines @@
         [strongSelf.get()->devices_ addObject:device];
         [strongSelf.get()->delegate_ scannerUpdatedDevices:weakSelf];
         [strongSelf.get()->finalUrls_ addObject:[device url]];
       }
     }
     [strongSelf.get()->pendingRequests_ removeObject:strongRequest];
   }];
 }
 
 @end