Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2113463003: Remove failure expectations in WPTServeExpectations for tests which use navigator.getUserMedia. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 5 months ago
Reviewers:
dcampb, Rick Byers, raikiri
CC:
blink-reviews, chromium-reviews, jsbell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove failure expectations in WPTServeExpectations for tests which use navigator.getUserMedia. In addition to removing the failure expectations associated with http://crbug.com/608457, this CL also sorts expectation lines in the file, and changes expectations based on local runs on my workstation: Added pass expectations: crbug.com/508725 imported/wpt/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script.html [ Pass ] crbug.com/508725 imported/wpt/mediacapture-streams/GUM-trivial-constraint.https.html [ Pass ] crbug.com/508725 imported/wpt/pointerevents/pointerevent_constructor.html [ Pass ] Removed failure expectations: crbug.com/508734 imported/wpt/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-fixed.html [ Timeout ] BUG=608457 Committed: https://crrev.com/fd3f30488622ed47d21a15b35fe0977215989d02 Cr-Commit-Position: refs/heads/master@{#403181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/WPTServeExpectations View 3 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
qyearsley
4 years, 5 months ago (2016-06-29 22:42:17 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113463003/1
4 years, 5 months ago (2016-06-29 22:43:47 UTC) #7
Rick Byers
LGTM
4 years, 5 months ago (2016-06-29 22:47:11 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 00:13:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113463003/1
4 years, 5 months ago (2016-06-30 15:16:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 15:20:32 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 15:20:35 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 15:22:16 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd3f30488622ed47d21a15b35fe0977215989d02
Cr-Commit-Position: refs/heads/master@{#403181}

Powered by Google App Engine
This is Rietveld 408576698